Skip to content

ci/test: run jobs on ubuntu-20.04, instead of ubuntu-18.04 #1978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

umarcor
Copy link
Contributor

@umarcor umarcor commented Feb 13, 2022

Description

Since the base image of the Dockerfile is to be updated to ubuntu:focal (see #1970), this PR changes the environment used in the jobs of workflow 'test'.

Related Issue

Motivation and Context

Ubuntu 18.04 is maintained until April 2023 (see https://endoflife.software/operating-systems/linux/ubuntu), however, Ubuntu 20.04 is also LTS. Hence, it is sensible to bump the environment, despite 18.04 not being EOL yet.

How Has This Been Tested?

It's CI, so self tested.

Types of changes

  • Bug fix (change which fixes an issue)
  • New feature (change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

@github-actions github-actions bot added the infra Project Infrastructure label Feb 13, 2022
Copy link
Contributor

@mithro mithro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While we don't have to run everything on it, we should have at least some running jobs on the oldest OS version we support?

@umarcor
Copy link
Contributor Author

umarcor commented Feb 23, 2022

@mithro, I believe there is an specific job/matrix for that: https://github.com/verilog-to-routing/vtr-verilog-to-routing/blob/master/.github/workflows/test.yml#L278-L310. So, the purpose of "Compatibility" is to evaluate the build on multiple OS versions. On the other hand, the rest of the jobs are all executed on the same (ubuntu-18.04 now, ubuntu-20.04 proposed).

@umarcor
Copy link
Contributor Author

umarcor commented Jul 27, 2022

@vaughnbetz @mithro can we have this merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infra Project Infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants