Skip to content

ci: add GitHub Actions workflow 'Containers' #1974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 23, 2022

Conversation

umarcor
Copy link
Contributor

@umarcor umarcor commented Feb 13, 2022

Description

As discussed in #1970, this PR adds a CI workflow to test building the Dockerfile, and to push it to ghcr.io.

Related Issue

Motivation and Context

Test when the Dockerfile breaks.

How Has This Been Tested?

It's CI, so self-tested.

Types of changes

  • Bug fix (change which fixes an issue)
  • New feature (change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

@github-actions github-actions bot added the infra Project Infrastructure label Feb 13, 2022
@umarcor
Copy link
Contributor Author

umarcor commented Feb 13, 2022

@alirezazd, I will keep this as a draft until #1970 is merged, or you can cherry-pick; as you wish.

@umarcor umarcor marked this pull request as ready for review February 23, 2022 02:33
@umarcor
Copy link
Contributor Author

umarcor commented Feb 23, 2022

This is now ready for review.

Copy link
Contributor

@mithro mithro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mithro mithro merged commit ae6e992 into verilog-to-routing:master Feb 23, 2022
@umarcor umarcor deleted the ci/container branch February 23, 2022 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infra Project Infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants