-
Notifications
You must be signed in to change notification settings - Fork 415
VPR: Add options for writing machine readable summary files #1947
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VPR: Add options for writing machine readable summary files #1947
Conversation
@lpawelcz - VPR has generally used XML for all the other file formats, I think it would be better to stick with that file format. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, apart from a small typo.
@mithro regarding the XML vs JSON format, I believe that, for such cases, where the output structure is quite simple, JSON is a better fit.
As an alternative, we may enable to output both, based on the file extensions.
ebe1765
to
aa27355
Compare
New options now are able to select between XML and JSON formats based on the extension of the file passed with those options |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
The new files formats should be documented in page at https://docs.verilogtorouting.org/en/latest/vpr/file_formats/ (which seems to be https://github.com/verilog-to-routing/vtr-verilog-to-routing/blob/master/doc/src/vpr/file_formats.rst ?). |
ab27f1a
to
709bd7d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just two minor comments.
Please check the ReadTheDocs looks good.
Merge if @acomodi and @vaughnbetz are happy.
709bd7d
to
aca55c9
Compare
Code blocks in docs were actually broken, sorry for that, they are OK now. Additionally, I noticed that I didn't update the command line options in docs when I added support for TXT files so I also fixed this. |
Hi @vaughnbetz, I think this one is ready. Please have a look at it and merge if there is nothing more to change here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good; just a few places where I suggest documenting that these are cluster-level netlist statistics. This can be merged and the commenting updated in another PR if you prefer.
aca55c9
to
0acd071
Compare
Signed-off-by: Paweł Czarnecki <[email protected]>
Signed-off-by: Pawel Czarnecki <[email protected]>
Signed-off-by: Pawel Czarnecki <[email protected]>
Signed-off-by: Pawel Czarnecki <[email protected]>
…k_usage Signed-off-by: Pawel Czarnecki <[email protected]>
Signed-off-by: Pawel Czarnecki <[email protected]>
0acd071
to
db3039f
Compare
I updated docs, help message and text format as specified so another PR won't be needed. |
Merging this one, Thanks everybody for reviews and comments. |
Description
This PR adds 2 new options:
--write_block_usage
--write_timing_summary
which enable VPR to write two summary files in JSON format.
The first one reports the usage of specific blocks of given architecture for implemented design during packing step in format:
Second option writes final timing summary for the design evaluated in routing step. It consist of Critical Path Delay (cpd), Max Circuit Frequency (Fmax), setup Worst Negative Slack (sWNS), setup Total Negative Slack (sTNS). The format is as follows:
Related Issue
This feature was suggested in #1944
Motivation and Context
Information provided in generated JSON files is used in SymbiFlow to perform tests that verify the block usage and timings against reference values in order to catch possible regression.
Current way of getting the information from VPR requires parsing the log output in search of timing summary and block usage info. It would be better solution to let VPR prepare the output in easy to read format so that we won't rely on log output that could be changed in the future and cause failures in log parsers.
How Has This Been Tested?
This was tested locally by adding new options to calls to VPR in symbiflow and inspecting the resulting files.
Types of changes
Checklist: