Skip to content

Updated comments to elaborate configurable/non-configurable edges() #1942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 22, 2021
Merged

Updated comments to elaborate configurable/non-configurable edges() #1942

merged 2 commits into from
Dec 22, 2021

Conversation

behzadmehmood-rs
Copy link
Contributor

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Types of changes

  • Bug fix (change which fixes an issue)
  • New feature (change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

@github-actions github-actions bot added the VPR VPR FPGA Placement & Routing Tool label Dec 20, 2021
@behzadmehmood-rs behzadmehmood-rs self-assigned this Dec 20, 2021
tangxifan
tangxifan requested changes Dec 21, 2021
View reviewed changes
Copy link
Contributor

@tangxifan tangxifan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vaughnbetz I reviewed the code comments on configurable/non-configurable edges. I sugges the changes like this. Please let me know if it is detailed enough or not.

@tangxifan
Copy link
Contributor

Thanks @vaughnbetz for the insights.
@behzadmehmood-rs Once CI is green, I will propose to merge.

@tangxifan tangxifan merged commit ac252ad into verilog-to-routing:master Dec 22, 2021
@tangxifan tangxifan deleted the configurable_edges branch December 22, 2021 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vaughnbetz vaughnbetz vaughnbetz left review comments

@tangxifan tangxifan tangxifan approved these changes

Assignees

@behzadmehmood-rs behzadmehmood-rs

Labels
VPR VPR FPGA Placement & Routing Tool
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@behzadmehmood-rs @tangxifan @vaughnbetz @symbiflow-robot @umariqbal-rs