Update the vqm2blif parser to add support for Stratix 10 and Agliex vqm files #1936
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
declarations and assign statements
hexadecimal format
line, this character would not be considered part of TOKEN_ESCAPEID
be used for declaration of vectors
inside (* and *) delimiters are skipped
listed under available devices and the user can select them
vaughnbetz
approved these changes
Dec 17, 2021
| [ \t]+ /* skip white spaces */ | ||
| ! /* skip the logical operator ! applied on the input ports of the lut - this results in lut mask not being valid anoymore */ |
There was a problem hiding this comment.
probably want to explain this means inversion in the vqm netlist, but we are ignoring it (hence the LUTmask won't be correct).
| @@ -197,7 +197,9 @@ extern t_boolean buffd_outs; //user-set flag that regulates whether to keep buff | |||
| */ | |||
| const map<std::string, DeviceInfo> device_parameter_database { | |||
| // stratix 4 device | |||
There was a problem hiding this comment.
Add a more descriptive comment here (device family, combinational cell name, output name, 1?, dff name, dff output name).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR includes a few minor modifications to the vqm2blif parser. Small changes have been made to the parser grammar files (vqm_parser.l and vqm_parser.y) in order to achieve the following objectives:
The synthesis attributes and directives inside (* and *) delimiters should be ignored
The names that start with \ (called TOKEN_ESCAPEID) should be allowed to be used for declaration of a vector. Currently the name of the vectors can only start with alphabetic characters and _ (TOKEN_REGULARID).
If a line in the code ends with a TOKEN_ESCAPEID and there is no space between the token and the ; at the end of the line, ; should not be considered part of the TOKEN_ESCAPEID.
The ! operator is escaped. Though it should be noted that this results in the lut_mask parameter being incorrect after conversion from VQM to BLIF.
Bit strings in hexadecimal format (nh’[0-9|A-F]+) should be accepted by the parser.
If the declarations and statements appear in a mixed order the parser should still be able to successfully parse the VQM file.
Related Issue
This PR is related to the issue #1931
Motivation and Context
The purpose of these modifications is to enable the tool to parse the Quartus VQM files targeting Stratix 10 and Agilex. The current version of the parser grammar is written based on the VQM files targeting Stratix IV devices. The new VQM files cannot successfully go through the parser as they differ slightly in formatting.
How Has This Been Tested?
In order to be able to test the changes, the architecture description of Stratix 10 or Agilex is required. The tests will be included in a different pull request once the architecture capture of one of these two devices has reached a major milestone.
Types of changes
Checklist: