Skip to content

Small improvements to string description of rr nodes #1915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 18, 2021
Merged

Small improvements to string description of rr nodes #1915

merged 2 commits into from
Nov 18, 2021

Conversation

jgoeders
Copy link
Contributor

This fixes two issues with the string description of rr nodes (describe_rr_node)

  1. Adds a missing space character.
  2. Adds the x,y location for SINK and SOURCE rr nodes. This was previously missing and it made it difficult to locate a given SOURCE/SINK rr node from an error message (in my case it was failed routing error message that only printed SOURCE and SINK description).

Types of changes

  • Bug fix (change which fixes an issue)
  • New feature (change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

@github-actions github-actions bot added the VPR VPR FPGA Placement & Routing Tool label Nov 17, 2021
@jgoeders jgoeders merged commit 3dbf54f into verilog-to-routing:master Nov 18, 2021
@jgoeders jgoeders deleted the describe_rr_node branch November 18, 2021 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
VPR VPR FPGA Placement & Routing Tool
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jgoeders