Skip to content

Updating the unit test framework (Catch) used to the latest version #1913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Nov 18, 2021

Conversation

Srivat97
Copy link
Contributor

VTR uses Catch as its unit test framework. Currently, the version used by VTR is outdated (version 1), the changes in this PR upgrade Catch to the latest version. Additionally, any projects that originally used the older version of Catch were also updated to use the latest version.

Description

  • The older version of Catch was removed
  • The latest version of Catch was added using git subtrees
  • All projects that used the older version of Catch were updated to use the newer version (this involved modifying include headers and also updating some source code that was specific to the older version of Catch)

Related Issue

This PR is related to issue https://github.com/verilog-to-routing/vtr-verilog-to-routing/issues/1909

Motivation and Context

Latest version of Catch supports newer c++ versions and also has newer features.

How Has This Been Tested?

This change has been tested by running all the unit tests and comparing the outputs with the older version of catch and making sure there were no differences.

Types of changes

  • Bug fix (change which fixes an issue)
  • New feature (change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

@github-actions github-actions bot added external_libs libvtrutil VPR VPR FPGA Placement & Routing Tool labels Nov 16, 2021
@vaughnbetz
Copy link
Contributor

Looks good to me; thanks @Srivat97 . @kmurray, @acomodi : let me know if you have any concerns. If not I'll merge this tonight.

Copy link
Contributor

@vaughnbetz vaughnbetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@acomodi acomodi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vaughnbetz vaughnbetz merged commit c918007 into master Nov 18, 2021
@vaughnbetz vaughnbetz deleted the updating_test_framework branch November 18, 2021 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external_libs libvtrutil VPR VPR FPGA Placement & Routing Tool
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants