Skip to content

Add a new APIs reserve_nodes() and resize_nodes to RRGraphBuilder #1905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 2, 2021
Merged

Add a new APIs reserve_nodes() and resize_nodes to RRGraphBuilder #1905

merged 6 commits into from
Nov 2, 2021

Conversation

m-hariszafar
Copy link

@m-hariszafar m-hariszafar commented Nov 1, 2021

Description
This PR focuses on updating routing resource graph builder functions, where we use the refactored data structure RRGraphBuilder to shadow the discrete data structure rr_graph_storage.
This PR aims to fully refactored/deprecate the direct use of the legacy APIs reserve() and resize() from the rr_node data structure if present there.

After this PR, the reserve_nodes() and resize_nodes() from the refactored data structure RRGraphBuilder is the only way to use it.

Checklist:

  • Removed the legacy API reserve() and resize() from rr_node.cpp and rr_node.h (if present)
  • Added new APIs reserve_nodes() and resize_nodes() to data structures RRGraphBuilder, whose comments are Doxygen compatible
  • Replaced all the use of reserve(), resize() with reserve_nodes(), resize_nodes() respectively, from respective client functions (if needed)

Related Issue
This pull request is a follow-up PR on the routing resource graph refactoring effort #1805, #1868

Motivation and Context
This PR is a continuation of the refactoring effort with a focus on shadowing the rr_graph_storage APIs in the RRGraphBuilder data structure.
This PR refactored the reserve_nodes() and resize_nodes() API among the other APIs in #1847, #1868

How Has This Been Tested?

  • All vtr basic and strong tests are passing.

Types of changes

  • Bug fix (change which fixes an issue)
  • New feature (change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

@github-actions github-actions bot added the VPR VPR FPGA Placement & Routing Tool label Nov 1, 2021
@tangxifan
Copy link
Contributor

@hariszafar-lm Just need to resolve the conflicts. Code changes look clean. Once you provides QoR tests, I will propose to merge.

@m-hariszafar
Copy link
Author

QoR tests are completed and a quick summary is given below. QoR comparison files are also attached.

titan_quick_qor test:
flow run time 5.46% on average.
critical path delays 0% on average.
Peak memory usage -0.21% on average

vtr_reg_qor_chain_depop test:
Flow run time 5.2% on average.
critical path delays 0% on average.
Peak memory usage is -16.43% on average.

Here are the attached files
vtr_chain_depop.xlsx
titan_quick_qor.xlsx

@m-hariszafar m-hariszafar marked this pull request as ready for review November 2, 2021 04:46
Copy link
Contributor

@tangxifan tangxifan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tangxifan tangxifan merged commit efbad52 into verilog-to-routing:master Nov 2, 2021
@tangxifan tangxifan deleted the api_reserve_resize_nodes branch November 2, 2021 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
VPR VPR FPGA Placement & Routing Tool
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants