Skip to content

CMake: add initial interchange schema sources compilation #1870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

acomodi
Copy link
Collaborator

@acomodi acomodi commented Oct 12, 2021

Description

This PR adds a very initial step towards the FPGA interchange adoption and integration within VTR.

This step currently adds the FPGA interchange schema definitions as a submodule and, if the cmake cache variable is defined, the various capnp schemas are compiled and their srcs and headers generated, ready to be used in the VTR codebase.

How Has This Been Tested?

For now, the build process and cmake are enough to catch regressions when compiling the interchange schema files

Types of changes

  • Bug fix (change which fixes an issue)
  • New feature (change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

@acomodi acomodi force-pushed the acom/add-initial-ic-schema branch from b3f2263 to fa8fbb0 Compare October 12, 2021 16:11
@github-actions github-actions bot added build Build system external_libs infra Project Infrastructure lang-make CMake/Make code libarchfpga Library for handling FPGA Architecture descriptions labels Oct 12, 2021
@acomodi acomodi force-pushed the acom/add-initial-ic-schema branch 3 times, most recently from 3df28db to c280b3f Compare October 15, 2021 07:44
@github-actions github-actions bot removed the infra Project Infrastructure label Oct 15, 2021
@acomodi acomodi force-pushed the acom/add-initial-ic-schema branch from c280b3f to bad564e Compare October 15, 2021 07:46
@github-actions github-actions bot added the infra Project Infrastructure label Oct 15, 2021
@acomodi acomodi force-pushed the acom/add-initial-ic-schema branch from a583009 to bad564e Compare October 15, 2021 08:18
@github-actions github-actions bot removed the infra Project Infrastructure label Oct 15, 2021
@acomodi acomodi force-pushed the acom/add-initial-ic-schema branch 2 times, most recently from ec64c23 to b0d36b4 Compare October 20, 2021 08:48
@acomodi acomodi requested a review from vaughnbetz October 21, 2021 08:31
@acomodi
Copy link
Collaborator Author

acomodi commented Oct 22, 2021

@vaughnbetz I have added the interchange schema using the subtrees instead of submodules, similarly to all other external libraries.

CI went green and this PR can get a review pass

@acomodi
Copy link
Collaborator Author

acomodi commented Nov 3, 2021

Closing, superseded by #1907

@acomodi acomodi closed this Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Build system external_libs lang-make CMake/Make code libarchfpga Library for handling FPGA Architecture descriptions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants