Skip to content

Collected parse_results*.txt as artifacts from CI run #1867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 28, 2021
Merged

Collected parse_results*.txt as artifacts from CI run #1867

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6d235b5
[Cleanup] Removed failed keyword from artifact lable
ganeshgore Oct 7, 2021
616aee3
Added golden results as CI artifacts
ganeshgore Oct 7, 2021
576cef1
Updated CI setup
ganeshgore Oct 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ jobs:
- name: Upload artifact
uses: actions/upload-artifact@v2
with:
name: failed_${{matrix.name}}_regression_log
name: ${{matrix.name}}_regression_log
path: |
vtr_flow/**/*.log
vtr_flow/**/*.out
Expand All @@ -149,6 +149,13 @@ jobs:
vtr_flow/**/*.net
vtr_flow/**/*.r

- name: Upload golden results
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it's worth creating an additional step. I would add the file to the list in the existing upload-artifact step.
When these artifacts are used for some specific purpose, then it'd be pertinent to evaluate whether to split it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The *_regression_log artifact was getting bulky and the GitHub artifact download has low bandwidth.
That is why I created a separate artifact for golden results, maybe we can move more frequently needed files (like vtr_flow/**/*.log) also to this artifact. Just for quicker download and debug.
But if you think it is best to combine all in regression_log I will merge those two runs.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The point is that artifacts are cumbersome to deal with. The later the worse. Hence, if whatever needs to be done with this txt can be sorted out without uploading it as an artifact, that's desirable. In case uploading as an artifact is required, it'd be desirable to use it in a different step of the same workflow. Having it be an isolated artifact to be manually downloaded should be the worst case approach.

uses: actions/upload-artifact@v2
with:
name: ${{matrix.name}}_golden_results
path: |
vtr_flow/**/parse_results*.txt

Sanitized:
runs-on: ubuntu-18.04
strategy:
Expand Down