-
Notifications
You must be signed in to change notification settings - Fork 415
[Infra]: fix missing VTR time in parse_results #1863
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks. Kokoro didn't run; trying a force restart. Change looks fine ... could probably merge even without kokoro. |
@vaughnbetz Anytime. BTW, it seems there are continuous failures in all Kokoro runners caused by the following error:
Although I am not sure, I found a related post on the StackOverflow. |
Thanks. From the stackoverflow post it seems this may be a permissions issue on kokoro. @mithro : if you can have someone look into it that would be great. |
6480163
to
e973e8f
Compare
e973e8f
to
7510bf5
Compare
…ry usage stat that is added to the run_vtr_flow output Signed-off-by: Seyed Alireza Damghani <[email protected]>
7510bf5
to
d501b72
Compare
Should the regex look for the trailing comma, or just skip it as part of the .* ? |
@vaughnbetz - This regex coding only looks for the elapsed time here. In the following, you would find a sample vtr_flow.out, since the VPR memory usage is already reported in the parse_results.txt, I just wrote a code to ignore whatever is after the elapsed time.
UPDATE: my apologies, the comma is already included in the regex format:
|
Yes, I was asking about removing the comma from the regex (to make things less fragile). |
@vaughnbetz - I see, sorry for the misunderstanding. So, since the comma is connected to the "seconds," with regex is not possible to ignore it. Either we need to ignore entire "seconds," with |
Ok let's leave it as is then. |
Description
While a new VPR memory usage stat is added to the run_vtr_flow output, the value of VTR elapsed time is no longer read by parse scripts due to a mismatch in the corresponding regex expressions.
Related Issue
Motivation and Context
How Has This Been Tested?
Types of changes
Checklist: