Skip to content

[Infra]: fix missing VTR time in parse_results #1863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 23, 2021
Merged

Conversation

sdamghan
Copy link
Member

Description

While a new VPR memory usage stat is added to the run_vtr_flow output, the value of VTR elapsed time is no longer read by parse scripts due to a mismatch in the corresponding regex expressions.

Related Issue

Motivation and Context

How Has This Been Tested?

Types of changes

  • Bug fix (change which fixes an issue)
  • New feature (change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

@vaughnbetz vaughnbetz added ABC ABC Logic Optimization & Technology Mapping Tool kokoro:force-run and removed ABC ABC Logic Optimization & Technology Mapping Tool labels Sep 30, 2021
@vaughnbetz
Copy link
Contributor

Thanks. Kokoro didn't run; trying a force restart. Change looks fine ... could probably merge even without kokoro.

@sdamghan
Copy link
Member Author

@vaughnbetz Anytime. BTW, it seems there are continuous failures in all Kokoro runners caused by the following error:

++ sudo apt-key add -
gpg: no valid OpenPGP data found.


[ID: 1004054] Build finished after 27 secs, exit value: 2


Warning: Permanently added 'localhost' (ED25519) to the list of known hosts.
[15:19:51] Collecting build artifacts from build VM
Build script failed with exit code: 2

Although I am not sure, I found a related post on the StackOverflow.

@vaughnbetz
Copy link
Contributor

Thanks. From the stackoverflow post it seems this may be a permissions issue on kokoro. @mithro : if you can have someone look into it that would be great.
@sdamghan : that stack overflow post also suggests some alternative command formulations that might work. If you have time and they look like potential solutions it would be good if you could try them out.

@sdamghan sdamghan mentioned this pull request Sep 30, 2021
7 tasks
@sdamghan sdamghan force-pushed the fix_parse_vtr_time branch from 6480163 to e973e8f Compare October 2, 2021 14:55
…ry usage stat that is added to the run_vtr_flow output

Signed-off-by: Seyed Alireza Damghani <[email protected]>
@vaughnbetz
Copy link
Contributor

Should the regex look for the trailing comma, or just skip it as part of the .* ?
It seems like not explicitly coding the "look for a comma" in the regex could make this more robust to future changes.

@sdamghan
Copy link
Member Author

sdamghan commented Nov 23, 2021

Should the regex look for the trailing comma, or just skip it as part of the .* ? It seems like not explicitly coding the "look for a comma" in the regex could make this more robust to future changes.

@vaughnbetz - This regex coding only looks for the elapsed time here. In the following, you would find a sample vtr_flow.out, since the VPR memory usage is already reported in the parse_results.txt, I just wrote a code to ignore whatever is after the elapsed time.

k4_N10_memSize16384_memData64/single_wire		OK (took 0.16 seconds, vpr run consumed 22.85 MiB memory)

UPDATE: my apologies, the comma is already included in the regex format:

                  here
-------------------*---
\(took (.*) seconds, .*\)

@vaughnbetz
Copy link
Contributor

Yes, I was asking about removing the comma from the regex (to make things less fragile).

@sdamghan
Copy link
Member Author

@vaughnbetz - I see, sorry for the misunderstanding. So, since the comma is connected to the "seconds," with regex is not possible to ignore it. Either we need to ignore entire "seconds," with \(took (.*) .*\) or whatever is after "seconds, " (the space after "," is the point here) as the current changes. Could you please let me know which one would you prefer?

@vaughnbetz
Copy link
Contributor

Ok let's leave it as is then.

@sdamghan sdamghan merged commit f92cfeb into master Nov 23, 2021
@sdamghan sdamghan deleted the fix_parse_vtr_time branch November 23, 2021 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants