Skip to content

Add a new API set_node_direction() to RRGraphBuilder #1854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Add a new API set_node_direction() to RRGraphBuilder #1854

wants to merge 5 commits into from

Conversation

m-hariszafar
Copy link

@m-hariszafar m-hariszafar commented Sep 22, 2021

Description

This PR focuses on updating routing resource graph builder functions, where we use the refactored data structure RRGraphBuilder to shadow the discrete data structure rr_graph_storage.
This PR aims to fully deprecate the direct use of the legacy API set_direction() from the rr_node data structure.

After this PR, the set_direction API is fully deprecated and the set_node_direction from the refactored data structure RRGraphBuilder is the only way to use it.

Checklist:

  • Removed the legacy API set_direction() from rr_node.cpp and rr_node.h
  • Added new APIs set_node_direction to data structures RRGraphBuilder, whose comments are Doxygen compatible
  • Replaced all the use of set_direction() in builder functions by set_node_direction()

Related Issue

This pull request is a follow-up PR on the routing resource graph refactoring effort #1805

Motivation and Context

This PR is the continuation of the refactoring effort with a focus on shadowing the rr_graph_storage APIs in the RRGraphBuilder data structure.
This PR reworks the set_node_direction() API among the other APIs in #1847

How Has This Been Tested?

  • All vtr basic and strong tests are passing.

Types of changes

  • Bug fix (change which fixes an issue)
  • New feature (change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

@github-actions github-actions bot added the VPR VPR FPGA Placement & Routing Tool label Sep 22, 2021
@m-hariszafar m-hariszafar deleted the api_node_direction branch September 23, 2021 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
VPR VPR FPGA Placement & Routing Tool
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant