[nix] drop python 2.7 #1793
Merged
[nix] drop python 2.7 #1793
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vaughnbetz
reviewed
Jul 30, 2021
|
Seems like a reasonable change; just kicked off CI. I suggest commenting why we're pinning this though, as someday we'll want to unpin or update it to a later version again. |
|
Actually, this is not very good as-is. I since found better mechanisms, that would likely let this build on latest dependencies. |
|
Thanks @sjkelly. If you can add those changes instead that would be great. |
|
The simpler fix was simply dropping python 27. PR has been updated. cc @HackerFoo |
|
LGTM, thanks. Just waiting for CI to go green. |
|
Think CI is green. Would like to have this for packaging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pins the local nix shell channel to 20.09, a known working version.Drop Python 2.7 in the the nix shell
Description
There are issues with Python 2.7 deprecations in the latest 21.05 channel, that cause errors
in nix-shell startup.
I have not investigated further, just want to build VTR :)Related Issue
N/A
Motivation and Context
The described actions in: https://docs.verilogtorouting.org/en/latest/building/building/#using-nix
did not work as expected.
How Has This Been Tested?
Local tests using:
Types of changes
Checklist:
N/A for the above.