Skip to content

Gitpod configuration #1766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 9, 2021
Merged

Conversation

sdamghan
Copy link
Member

@sdamghan sdamghan commented Jun 4, 2021

Description

  1. The origin remote of the repository in Gitpod was the Loksu fork -> changed to the main VTR repo
  2. Running tasks in the gitpod.yml caused errors at the starting point of the Gitpod -> removed
  3. Setting the working directory for the docker file as VTR_ROOT env.

Related Issue

Motivation and Context

wrong URL and removing errors

How Has This Been Tested?

Types of changes

  • Bug fix (change which fixes an issue)
  • New feature (change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

@github-actions github-actions bot added the docs Documentation label Jun 4, 2021
@sdamghan
Copy link
Member Author

sdamghan commented Jun 4, 2021

@mithro the GitPod is a pretty cool tool, thanks for introducing it. I've just made a couple of changes, please let me know your thoughts.

@sdamghan sdamghan requested a review from mithro June 4, 2021 03:44
@sdamghan sdamghan force-pushed the origin_remote_gitpod branch from 0d5fff9 to 005cc36 Compare June 4, 2021 03:47
@mithro
Copy link
Contributor

mithro commented Jun 4, 2021

LGTM!

We should be testing in CI that GitPod is working in some way?

@github-actions github-actions bot added the Odin Odin II Logic Synthesis Tool: Unsorted item label Jun 8, 2021
@sdamghan sdamghan force-pushed the origin_remote_gitpod branch 4 times, most recently from bf336da to 0248cbb Compare June 8, 2021 23:33
@sdamghan
Copy link
Member Author

sdamghan commented Jun 8, 2021

We need to install GitPod (link) on the VTR repo. Afterwards, with changes in this Pr we should see a GitPod record to PR checks, like below:
SS

Link to above PR: sdamghan/gitpod#1
Link to install GitPod guide: https://www.gitpod.io/docs/prebuilds/#configure-the-github-app

@github-actions github-actions bot removed the Odin Odin II Logic Synthesis Tool: Unsorted item label Jun 8, 2021
@mithro
Copy link
Contributor

mithro commented Jun 9, 2021

I have configured the GitPod GitHub App as requested.

Copy link
Contributor

@mithro mithro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

sdamghan added 4 commits June 8, 2021 20:00
	 - Adding VTR_ROOT env and set as docekr working directory

Signed-off-by: Seyed Alireza Damghani <[email protected]>
@mithro mithro force-pushed the origin_remote_gitpod branch from 0248cbb to db522c5 Compare June 9, 2021 03:04
@mithro mithro merged commit 35dc734 into verilog-to-routing:master Jun 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants