-
Notifications
You must be signed in to change notification settings - Fork 415
Gitpod configuration #1766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gitpod configuration #1766
Conversation
@mithro the GitPod is a pretty cool tool, thanks for introducing it. I've just made a couple of changes, please let me know your thoughts. |
0d5fff9
to
005cc36
Compare
LGTM! We should be testing in CI that GitPod is working in some way? |
bf336da
to
0248cbb
Compare
We need to install GitPod (link) on the VTR repo. Afterwards, with changes in this Pr we should see a GitPod record to PR checks, like below: Link to above PR: sdamghan/gitpod#1 |
I have configured the GitPod GitHub App as requested. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Signed-off-by: Seyed Alireza Damghani <[email protected]>
…arting point) Signed-off-by: Seyed Alireza Damghani <[email protected]>
- Adding VTR_ROOT env and set as docekr working directory Signed-off-by: Seyed Alireza Damghani <[email protected]>
Signed-off-by: Seyed Alireza Damghani <[email protected]>
0248cbb
to
db522c5
Compare
Description
gitpod.yml
caused errors at the starting point of the Gitpod -> removedRelated Issue
Motivation and Context
wrong URL and removing errors
How Has This Been Tested?
Types of changes
Checklist: