-
Notifications
You must be signed in to change notification settings - Fork 416
Avoiding Odin's xml config file to be considered as arch file #1758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@sdamghan : I think you should add a comment in some appropriate place about why you use the .oxml extension though (so the flow scripts don't think this is an architecture file). Is there any downside to renaming these files .oxml? E.g. can you open them with an xml viewer? Not a major concern for me if it doesn't bother you, but thought I'd ask in case there is an alternative way to get this warning to go away (e.g. make upgrade_vtr_archs.sh a bit smarter, having it avoid files that have _odin.xml in their name, or make the flow script calling it a bit smarter, etc. |
@vaughnbetz Odin's configuration file is actually an XML file. To remove the warnings related to Odin in |
I actually think it is more clear if we keep the standard extension (.xml) so the format is obvious. That's usually what a filename extension means -- if it is a standard format, the extension says what it is. That lets OS'es figure out how to open it etc. If we can just change upgrade_vtr_archs.sh to skip the odin-II files (since it doesn't need to upgrade them or know how to do it) I think that's best. Is simply removing OdinII from the directory list at https://github.com/verilog-to-routing/vtr-verilog-to-routing/blob/master/dev/upgrade_vtr_archs.sh doable? If that's not doable, using ODIN-II config files that are something like _odin.xml would let us remove them with a filename matching rule in the upgrade_vtr_archs.sh script, which I think is also OK. |
Signed-off-by: Seyed Alireza Damghani <[email protected]>
Thanks. This is a nice simple fix! |
Signed-off-by: Seyed Alireza Damghani [email protected]
Description
the following warnings are showing while
dev/upgrade_vtr_archs.sh
is called. Odin's XMLs are to read the configuration of each run. There is no need to go through the Odin directory looking for XML files.Related Issue
Motivation and Context
removing warning generated by
upgrade_vtr_arch.sh
How Has This Been Tested?
Types of changes
Checklist: