Initializing defined_size in VNumber Copy constructor

[sdamghan]

Signed-off-by: Seyed Alireza Damghani [email protected]

Description

In VNumber copy constructor with new length, the defined_size variable was not initialized. As a result, Odin_II would throw an error in case of facing new VNumbers without defined_size equal to true while they have already a size specified.

Related Issue

#1738

Motivation and Context

Bug fix!

How Has This Been Tested?

Types of changes

• Bug fix (change which fixes an issue)
• New feature (change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• My change requires a change to the documentation
• I have updated the documentation accordingly
• I have added tests to cover my changes
• All new and existing tests passed

[sdamghan]

@ArashAhmadian Thanks for finding the bug!
This PR would fix the last issue you mentioned in the email. Waiting for CI green checkmarks then will be merged.
Please feel free to add more information on the related issue.

[ArashAhmadian]

@sdamghan Great! Thanks for letting me know.

[sdamghan]

@vaughnbetz This PR is ready to merge as well.

[ArashAhmadian]

@vaughnbetz Could you merge this PR?

[vaughnbetz]

I'm going to let CI keep going overnight as I want to see if vtr_nightly_reg works this time (indicating it was a transient kokoro issue). Will merge tomorrow morning.

[ArashAhmadian]

I'm going to let CI keep going overnight as I want to see if vtr_nightly_reg works this time (indicating it was a transient kokoro issue). Will merge tomorrow morning.

Sounds good.

[vaughnbetz]

All CI passed, so the kokoro failure was transient.

[sdamghan]

Awesome, thanks @vaughnbetz