Deprecate node_side() API #1694
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
litghost
reviewed
Mar 25, 2021
vpr/src/route/rr_node.cpp
Outdated
| @@ -25,7 +25,13 @@ const char* t_rr_node::direction_string() const { | |||
| } | |||
|
|
|||
| const char* t_rr_node::side_string() const { | |||
There was a problem hiding this comment.
Probably need to deprecate this one too?
There was a problem hiding this comment.
Seems reasonable to deprecate.
There was a problem hiding this comment.
@litghost @vaughnbetz The method has been deprecated
|
Thanks Xifan; looks good. Will merge as soon as CI goes green. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the final PR in the PR series #1667 and #1661 to replace node_side() API with is_node_on_specific_side() APIs
Description
Related Issue
To address issue #1577
Motivation and Context
To address issue #1577
How Has This Been Tested?
Should have no impact to existing codes as the node_side() API is almost unused.
Types of changes
Checklist: