-
Notifications
You must be signed in to change notification settings - Fork 415
Clusterer feasibility changes #1641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 22 commits
918219f
1fdf881
ca7b577
ed6e7a8
532a143
511a994
8008b2e
54f4995
5845338
7b465fe
6fb45ff
3a606e8
4fceb1e
f00d55d
f34a1d6
e4b8257
6e59e42
ffa49a1
83cfe2b
ed0cd07
7e8f9d5
c8b58b8
f11da67
899a3da
afcb926
ee4bf86
37ef5a7
cfb812f
e2a7bfc
680cbdc
40e9534
d2d6fcb
bd217bf
8c5bc25
b807f83
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -12,6 +12,9 @@ enum e_echo_files { | |
E_ECHO_PRE_PACKING_MOLECULES_AND_PATTERNS, | ||
E_ECHO_VPR_CONSTRAINTS, | ||
|
||
//Packing | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. At top, file controls echo files, we have an enum to each one, search for in code to see what each one prints There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. say what echo files are, what they are used for - dumps that intended to be written and read by a developer, typically direct reps of data structures to make debugging easier There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. enum e_output_files - line 66 - see what these are in code and leave a brief comment, or make an issue saying this may just be same as other enum and we should just put them both together There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. set an issue to clean up these two enums (either just need to comment, or merge the two diff enums) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. echo file name can maybe also take a default name (person can choose to pass it in - if not, default set to null), the set_output_filename would work fore everything investigate - is there some other reason to have the second output enum? - look at the call sites for that in the cpp file -> instead of the mallocs, recode using c++ strings and wrap it all in a class -> all the members of the class could be static members (don't have to turn into class, see if it's worth it) (make a member object of the echo class in something like the vpr_options file)
|
||
E_ECHO_CLUSTERS, | ||
|
||
// Intra-block routing | ||
E_ECHO_INTRA_LB_FAILED_ROUTE, | ||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -164,6 +164,7 @@ enum e_block_pack_status { | |
BLK_PASSED, | ||
BLK_FAILED_FEASIBLE, | ||
BLK_FAILED_ROUTE, | ||
BLK_FAILED_FLOORPLANNING, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. think about whether this enum can be in a lower header file. If it's only used in the clusterer, can have a cluster_utilities header file and put this enum in there. This can be a cleanup on a separate pull request There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. in pack subdirectory - is there a cluster utilities type header file? check, could possibly put there |
||
BLK_STATUS_UNDEFINED | ||
}; | ||
|
||
|
Uh oh!
There was an error while loading. Please reload this page.