Vtr log changes #1637
Merged
Vtr log changes #1637
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ier in the vpr_stdout.log file
|
While making these changes, I noticed that there are some functions in vpr_api.cpp that are written but never called (ex. vpr_show_setup, vpr_setup_vpr). The api code just directly calls the functions (ShowSetup, SetupVPR) that are called within vpr_show_setup and vpr_setup_vpr. |
|
@litghost nightly has been taking a long time on this. |
|
This job is just running normally, right now. Long poles are: |
|
@litghost is nightly still running normally here? It has been running for almost 24h now |
It has terminated in failure for two reasons. The first was some QoR failures: The other reason is that the working space for the job exceeded 50 GiB (or 100 GiB). We likely need to cleanup the workspace after running to remove files that consume space. See what was done over here for inspiration: https://github.com/SymbiFlow/symbiflow-arch-defs/blob/45c83a2592923b9a785aa05c9464b5f453ebd151/.github/kokoro/package_results.sh#L12-L48 |
Ok thanks, I'll look into that |
|
@sfkhalid should we merge this? |
|
Yes, I think we can, it just changes the order of some things in the vpr stdout log file. It only shows the same QoR failures as the ones on other branches. But I think we'll have to update the branch first. |
|
@sfkhalid: this failed with error code 127 in vtr_reg_nightly; so did another recent test. I merged the change to bring back compressed result files and relaunched CI (plus I merged a few other PRs over the last day or two). Sarah can you take a look into this and see what's failing? Is it a build script failure due to the bringing back compressed files? Something else? It looks like there may be a hanging / running out of time / other issue with vtr_reg_nightly so it's important we figure it out quickly and get it fixed. |
|
Seyed's PR has a similar failure, but nothing passed before it just seemed to hang. Maybe there is an issue with kokoro and it is hung? Restarting CI to see if the issue is resolved. |
|
@vaughnbetz Nightly has passed on this pull request and on my more recent PR #1741. |
|
When I ran nightly locally on this branch there were 4 QoR failures in titan_quick_qor. I updated the local branch to make sure it was the same as the remote, so I am not sure where the differences are coming from.
|
|
OK, glad this was a transient error! The QoR failures are all really the same failure: placement stretched the critical path on one design by ~50%, which is more than the allowed 40%. WNS matches the critical path delay (largely reporting the same thing) and routing values follow the placement values as the router can't fix a bad placement. So the local failure is probably just a very unlucky compile/seed noise. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made changes to vpr_stdout.log output
Description
Related Issue
These changes were suggested in issue #1617