-
Notifications
You must be signed in to change notification settings - Fork 416
Vpr constraints parsing #1600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vpr constraints parsing #1600
Conversation
#include "constraints_load.h" | ||
#include "vtr_log.h" | ||
#include "globals.h" //for the g_vpr_ctx | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have a block comment at the top explaining which functions go with read functionality, and which go with write functionality, etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can point to the rr_graph tutorial for more info
virtual void finish_load() final { | ||
} | ||
|
||
//temp data for loads |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comment what all of these are
virtual inline void set_add_atom_name_pattern(const char* name_pattern, void*& /*ctx*/) final { | ||
auto& atom_ctx = g_vpr_ctx.atom(); | ||
std::string atom_name = name_pattern; | ||
atom_id_ = atom_ctx.nlist.find_block(name_pattern); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have a warning if you encounter name_pattern that doesnt match anything
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comment what happens when invalid
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for regex -> atom_id_ to a vector of atom ids because you may get multiple atom ids that match a regular expression
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Check for invalid names, check that in. --> Merge after this
- Check for signal names, check in. --> new branch off master
- Check for wildcard names, check in.
* <xs:attribute name="subtile" type="xs:int" /> | ||
* </xs:complexType> | ||
*/ | ||
virtual inline int get_add_region_subtile(void*& /*ctx*/) final { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for functions that are stubbed out, comment
loaded_partition.set_name(name); | ||
} | ||
|
||
virtual inline void preallocate_partition_add_atom(void*& /*ctx*/, size_t /*size*/) final {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
called when processing atoms, but not used
constraints_.add_partition(loaded_partition); | ||
|
||
num_partitions_++; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add a space
…ed fix to resolve compiler warning
Description
All the changes made on this branch were to facilitate parsing vpr constraints files. An option called "--read_vpr_constraints" was created and the uxsdcxx library was used to generate parsing files based on an XML schema called vpr_constraints.xsd
Types of changes
Checklist: