Skip to content

Remove Legacy Codes about trim_empty_channels and trim_obs_channels #1596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

tangxifan
Copy link
Contributor

@tangxifan tangxifan commented Nov 18, 2020

This PR remove the legacy codes from VPR codes base due to the obsoleted options trim_empty_channels and trim_obs_channels.

Description

The options impact only two parts of VPR:

  • The setup function SetupVPR() where the options are loaded
  • The routing resource graph builder build_rr_graph() where the options are input arguments and force modification on routing channels.

Related Issue

To address issue #1552

Motivation and Context

The dead codes are no longer used in any tests and their functionality have been fully covered by the custom switch block feature.

How Has This Been Tested?

This PR does just clean-up. The removed codes are never called in any tests.

Types of changes

  • Bug fix (change which fixes an issue)
  • New feature (change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

@github-actions github-actions bot added the VPR VPR FPGA Placement & Routing Tool label Nov 18, 2020
Copy link
Contributor

@kmurray kmurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, nice to see this code gone.

Copy link
Collaborator

@litghost litghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vaughnbetz
Copy link
Contributor

Looks good; thanks for cleaning up the code by getting rid of these!

@vaughnbetz vaughnbetz merged commit 8271fa9 into verilog-to-routing:master Nov 19, 2020
@tangxifan tangxifan deleted the rr_graph_dead_code_removal branch December 9, 2020 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
VPR VPR FPGA Placement & Routing Tool
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants