Code comment for #1591 #1595
Merged
Code comment for #1591 #1595
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vaughnbetz
reviewed
Nov 18, 2020
vpr/src/pack/prepack.cpp
Outdated
|
|
||
| /** | ||
| * It is required that the chain pins areconnected inside a complex | ||
| * block. Although it is allowed to have them disconnected in some of |
There was a problem hiding this comment.
Looks good, thanks.
A couple of typos to fix:
areconnected (missing space)
"in some of modes of the block" -> "in some modes of the block"
vaughnbetz
approved these changes
Nov 18, 2020
Signed-off-by: Maciej Kurc <[email protected]>
mkurc-ant
force-pushed
the
carry_assert_fix_comment
branch
from
894e1ac to
7b56616
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a code comment as requested in #1591
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Types of changes
Checklist: