Skip to content

Chain pack pattern assertion fix #1591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 12, 2020
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions vpr/src/pack/prepack.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1548,6 +1548,7 @@ static void update_chain_root_pins(t_pack_patterns* chain_pattern,
for (const auto pin_ptr : chain_input_pins) {
std::vector<t_pb_graph_pin*> connected_primitive_pins;
get_all_connected_primitive_pins(pin_ptr, connected_primitive_pins);
VTR_ASSERT(connected_primitive_pins.size());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest a comment here on the assert. I think the assert is checking that some primitive pin in some mode connects to the cluster level chain input pin.

primitive_input_pins.push_back(connected_primitive_pins);
}

Expand Down Expand Up @@ -1602,8 +1603,6 @@ static void get_all_connected_primitive_pins(const t_pb_graph_pin* cluster_input
}
}
}

VTR_ASSERT(connected_primitive_pins.size());
}

/**
Expand Down