check_rr_graph: fix bug when checking multi-connections between nodes #1579
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
litghost
reviewed
Oct 29, 2020
acomodi
force-pushed
the
fix-check-rr-graph-bug
branch
from
9a77245 to
59dace8
Compare
litghost
reviewed
Oct 29, 2020
acomodi
force-pushed
the
fix-check-rr-graph-bug
branch
from
59dace8 to
20dd02f
Compare
vaughnbetz
reviewed
Oct 29, 2020
Signed-off-by: Alessandro Comodi <[email protected]>
acomodi
force-pushed
the
fix-check-rr-graph-bug
branch
from
20dd02f to
9825c7f
Compare
|
All CIs went green and I have updated the comment. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Alessandro Comodi [email protected]
Description
There seems to be a bug in check_rr_graph related to the check on the multiple connections between RR nodes.
While dealing with f4pga/f4pga-arch-defs#1711 to fix the RR graph due to the presence of only one node for all the possible sides of a pin, I encountered the VPR error below:
Given that the comment prior to the check say that this pair of nodes can have multiple connections, I spotted a possible bug in the if statement.
Types of changes
Checklist: