Changes to enable custom ODIN configuration to vtr_flow experiments #1569
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This set of changes modifies ODIN allowing reading the simulation parameters from config files while reading list of files from command line arguments. Signed-off-by: Georgiy Krylov <[email protected]>
This set of changes introduces regression tests to test the configuration files from .xml files while reading the list of files and architecture from command line arguments. Signed-off-by: Georgiy Krylov <[email protected]>
This set of changes introduces the default results for regression tests to test the configuration files from .xml files while reading the list of files and architecture from command line arguments. Signed-off-by: Georgiy Krylov <[email protected]>
georgkrylov
changed the title
vaughnbetz
reviewed
Nov 8, 2020
doc/src/vtr/run_vtr_flow.rst
Outdated
|
|
||
| Tells VTR flow to use a custom ODIN II configuration value. The default | ||
| behavior is to use the vtr_flow/misc/basic_odin_config_split.xml. | ||
| Instead, an alternative config file might be supplied, compare the |
There was a problem hiding this comment.
minor nit, should be:
"supplied; compare the" (semicolon needed)
There was a problem hiding this comment.
Thank you @vaughnbetz for the review. I have updated the code with the changes you suggested. Any other change you'd like me to implement or is the PR good to go?
|
Looks good to me. One minor nit on the online documentation (grammatical fix). |
This set of changes introduces ability to modify the VTR flow through providing a custom default script. Also, fixes the problem of disable xml option crashing in odin.py and a problem with run_vtr_task.py followed by the name of the script. Changes to Python scripts. Signed-off-by: Georgiy Krylov <[email protected]>
georgkrylov
force-pushed
the
infra_changes_for_mixing
branch
from
6161827 to
703907b
Compare
|
Kokoro seems stuck; restarting it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This set of changes is designed to allow running full synthesis with custom .xml configuration supplied to ODIN as part of run_vtr_flow procedure. ODIN can now read command line parameters and mix them with configuration file. Also involves a couple of fixes to run_vtr_task and run_vtr_flow.
Related Issue
The discussion was held here
Motivation and Context
The change allows to configure experiments and enable custom ODIN arguments, since currently run_vtr_flow redirects extra command line arguments are redirected to VPR, so there is limited ability to modify ODIN parameters without editing run_vtr_flow.py
How Has This Been Tested?
There is a regression test and default results supplied within ODIN
Types of changes
Checklist: