Skip to content

Remove old perl scripts #1551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 21, 2020
Merged

Conversation

jgoeders
Copy link
Contributor

Remove old perl scripts that are no longer used by the VTR flow.

Description

Related Issue

Motivation and Context

#1509 #1429 introduced new python scripts to replace the Pythons scripts.

How Has This Been Tested?

Types of changes

  • Bug fix (change which fixes an issue)
  • New feature (change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

@probot-autolabeler probot-autolabeler bot added infra Project Infrastructure lang-perl Perl code scripts Utility & Infrastructure scripts tests VTR Flow VTR Design Flow (scripts/benchmarks/architectures) labels Sep 17, 2020
@vaughnbetz
Copy link
Contributor

A couple of travis ci failures. Looks like a few regtests are still trying to use the perl scripts which are being removed here. E.g. the NO_GRAPHICS tests:

The command "./.github/travis/build.sh" exited with 0.
0.01s$ travis_wait 30 ./run_reg_test.pl vtr_reg_basic -show_failures -j2
Still running (1 of 30): ./run_reg_test.pl vtr_reg_basic -show_failures -j2
The command ./run_reg_test.pl vtr_reg_basic -show_failures -j2 exited with 127.
Log:
/home/travis/.travis/functions: line 619: ./run_reg_test.pl: No such file or directory
/home/travis/.travis/functions: line 607: 6250 Terminated travis_jigger "${!}" "${timeout}" "${cmd[@]}"
The command "travis_wait 30 ./run_reg_test.pl vtr_reg_basic -show_failures -j2" exited with 127.

@jgoeders
Copy link
Contributor Author

Yes, fixed in #1553.

I'll continue working on making this PR green, then I'll leave it draft for a few weeks as we discussed.

@vaughnbetz
Copy link
Contributor

No issues so far, and CI is green. Leave draft for a while longer or merge now?

@jgoeders jgoeders marked this pull request as ready for review October 21, 2020 18:38
@jgoeders
Copy link
Contributor Author

@vaughnbetz Sorry, didn't see your earlier message. I think it's been a while now. I'll merge it.

@jgoeders jgoeders merged commit ab5f508 into verilog-to-routing:master Oct 21, 2020
@jgoeders jgoeders deleted the remove_perl_scripts branch October 21, 2020 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infra Project Infrastructure lang-perl Perl code scripts Utility & Infrastructure scripts tests VTR Flow VTR Design Flow (scripts/benchmarks/architectures)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants