Skip to content

run_vtr_flow.py: use VTR exe paths instead of searching on PATH #1532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Sep 11, 2020
Merged

run_vtr_flow.py: use VTR exe paths instead of searching on PATH #1532

merged 9 commits into from
Sep 11, 2020

Conversation

jgoeders
Copy link
Contributor

@jgoeders jgoeders commented Sep 10, 2020 •
edited
Loading

run_vtr_flow.py is currently looking for executables (abc, vpr, etc) on the PATH instead of using the paths to the compiled tools within the VTR repository. This fixes that issue

Description

Add new paths.py with python Pathlib paths for all VTR executable paths. Use these paths in run_vtr_flow.py

Related Issue

#1523

How Has This Been Tested?

Regression tests
As per #1523, tested vtr_reg_string with abc executable on PATH.

Types of changes

  • Bug fix (change which fixes an issue)
  • New feature (change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

@probot-autolabeler probot-autolabeler bot added ABC ABC Logic Optimization & Technology Mapping Tool infra Project Infrastructure lang-python Python code scripts Utility & Infrastructure scripts VTR Flow VTR Design Flow (scripts/benchmarks/architectures) labels Sep 10, 2020
@probot-autolabeler probot-autolabeler bot added the VPR VPR FPGA Placement & Routing Tool label Sep 10, 2020
@jgoeders jgoeders linked an issue Sep 11, 2020 that may be closed by this pull request
vtr_flow scripts search executable from system paths prior to ${VTR_ROOT} directory #1523
Closed
@jgoeders jgoeders marked this pull request as ready for review September 11, 2020 02:20
@jgoeders jgoeders merged commit 98810f8 into verilog-to-routing:master Sep 11, 2020
@jgoeders jgoeders mentioned this pull request Sep 11, 2020
Closed
@jgoeders jgoeders deleted the abc_path_fix branch September 11, 2020 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ABC ABC Logic Optimization & Technology Mapping Tool infra Project Infrastructure lang-python Python code scripts Utility & Infrastructure scripts VPR VPR FPGA Placement & Routing Tool VTR Flow VTR Design Flow (scripts/benchmarks/architectures)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

vtr_flow scripts search executable from system paths prior to ${VTR_ROOT} directory
1 participant
@jgoeders