Apply reordering to node and edge metadata #1516
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
probot-autolabeler
bot
added
lang-cpp
HackerFoo
force-pushed
the
reorder-metadata
branch
from
3a84e19 to
4e9debb
Compare
litghost
reviewed
Sep 1, 2020
Signed-off-by: Dusty DeWeese <[email protected]>
HackerFoo
force-pushed
the
reorder-metadata
branch
from
4e9debb to
70400be
Compare
litghost
requested changes
Sep 1, 2020
There was a problem hiding this comment.
Can you adapt the current metadata storage unit test https://github.com/verilog-to-routing/vtr-verilog-to-routing/blob/master/vpr/test/test_vpr.cpp#L114 to test this fix?
litghost
reviewed
Sep 1, 2020
HackerFoo
force-pushed
the
reorder-metadata
branch
from
83231fa to
31b48c3
Compare
Signed-off-by: Dusty DeWeese <[email protected]>
HackerFoo
force-pushed
the
reorder-metadata
branch
from
31b48c3 to
7811b27
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update RR graph node IDs in node and edge metadata when using RR graph node reordering.
Description
Bitstreams produced with node reordering (a
--reorder_rr_graph_nodes_algorithmother thannone) were not building withfasm2belsdue to scrambled metadata.Related Issue
#1270
Motivation and Context
This fixes metadata when using RR node reordering.
How Has This Been Tested?
fasm2belstests now pass onfpga-tool-perf.Types of changes
Checklist: