Skip to content

Adding suppression file to the new vtr-flow.py #1480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

shadtorrie
Copy link
Contributor

The suppression file has now been added to the new run_vtr_flow.py

Description

The old perl script included a suppression file to suppress various memory leak errors when sanitizing was enabled. This functionality was missed in the initial conversion of run_vtr_flow to python but it is being implemented here.

Related Issue

Should fix this issue
This could possibly fix this issue

Motivation and Context

Memory leaks in the vtr_reg_strong tests come up when sanitizing is enabled. This occurs mainly on the tests mentioned in the above issues. This causes some CI tests to fail on master.

How Has This Been Tested?

I unfortunately have been unable to reproduce the errors locally and am unable to test this fully.

Types of changes

  • Bug fix (change which fixes an issue)
  • New feature (change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

@probot-autolabeler probot-autolabeler bot added infra Project Infrastructure lang-python Python code scripts Utility & Infrastructure scripts VPR VPR FPGA Placement & Routing Tool VTR Flow VTR Design Flow (scripts/benchmarks/architectures) labels Aug 13, 2020
@shadtorrie
Copy link
Contributor Author

@vaughnbetz @sfkhalid I hope this fixes the memory leak issue. Let me know if there are any issues.

@vaughnbetz
Copy link
Contributor

Thanks, the code looks good to me.

Copy link
Contributor

@vaughnbetz vaughnbetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks.

@vaughnbetz vaughnbetz merged commit cc4b65d into verilog-to-routing:master Aug 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infra Project Infrastructure lang-python Python code scripts Utility & Infrastructure scripts VPR VPR FPGA Placement & Routing Tool VTR Flow VTR Design Flow (scripts/benchmarks/architectures)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vtr_reg_strong failures on master branch Memory leaks in vtr_reg_strong graphics test
4 participants