Vtr flow max router iteration fix #1460
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
probot-autolabeler
bot
added
infra
vaughnbetz
approved these changes
Aug 1, 2020
|
Thanks for the quick fix Shad! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The max_router_iteration value being passed into run_vtr_flow was not passed onto vpr.
Description
The default value for the parameter crit_path_router_iterations was overriding the inserted value of max_router_iteration, if max_router_iteration was directly input. This has been fixed
Related Issue
This issue is fixed here.
Motivation and Context
It is important to be able to pass parameters directly to vpr as well as pass them through the vtr flow.
How Has This Been Tested?
Ran the titan tests as described in the issue, and ensured that the max_router_iteration value passed in was the one VPR was given
Types of changes
Checklist: