-
Notifications
You must be signed in to change notification settings - Fork 415
Add PlacerSetupSlacks interface #1450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
f4ea4a1
c024603
cb6e9a6
63db2e1
aa7b233
e8f73c6
d80de58
831df44
d329911
225870e
9056301
0e01ed7
2e212dc
96e65ba
112bde5
29b55a3
da55abf
92c416a
870eca6
a2685c7
cc4488e
38f25cc
74d279c
9f18666
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,6 +2,7 @@ | |
#define VTR_SET_H | ||
|
||
#include <vector> | ||
#include <algorithm> | ||
|
||
namespace vtr { | ||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -851,7 +851,8 @@ struct t_annealing_sched { | |
* doPlacement: true if placement is supposed to be done in the CAD flow, false otherwise */ | ||
enum e_place_algorithm { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Comment what each enum constant chooses. |
||
BOUNDING_BOX_PLACE, | ||
PATH_TIMING_DRIVEN_PLACE | ||
PATH_TIMING_DRIVEN_PLACE, | ||
SETUP_SLACK_ANALYSIS_PLACE | ||
}; | ||
|
||
enum e_pad_loc_type { | ||
|
@@ -889,6 +890,12 @@ enum class e_place_delta_delay_algorithm { | |
DIJKSTRA_EXPANSION, | ||
}; | ||
|
||
enum class e_place_quench_metric { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Comment what each enum value does. Instead of TIMING_COST I think we should call the first one TIMING_CRITICALITY (or TIMING_CRITICALITY_COST if you prefer). |
||
TIMING_COST, | ||
SETUP_SLACK, | ||
AUTO | ||
}; | ||
|
||
struct t_placer_opts { | ||
enum e_place_algorithm place_algorithm; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It would be good to add comments for each data member here too. |
||
float timing_tradeoff; | ||
|
@@ -935,6 +942,7 @@ struct t_placer_opts { | |
std::string allowed_tiles_for_delay_model; | ||
|
||
e_place_delta_delay_algorithm place_delta_delay_matrix_calculation_method; | ||
e_place_quench_metric place_quench_metric; | ||
}; | ||
|
||
/* All the parameters controlling the router's operation are in this * | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why was this added?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After moving around the code, the compiler gave me an error saying
error: 'sort' is not a member of 'std'
in L79 of this file. That's why I added it.