Compiler directives benchmarks #1331
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
probot-autolabeler
bot
added
lang-cpp
|
it seems you added the Expected display but haven't regenerated all the expected results, travis Is currently failing because of this https://travis-ci.com/github/verilog-to-routing/vtr-verilog-to-routing/jobs/342806831. I would either consider dropping it for now or updating all of them. I like the idea and I do think it would be very usefull. |
|
Once Travis passes, it's ready to be merged |
…ectives which can be found in the preprocessor file. Additionally, created an "expected" option for json files that allows us to identify benchmarks that should be passed but fail due to bugs or unsupported functions. This allows developers creating benchmarks to go more in depth on why a test may be failing and possible solutions. All json files have been updated accordingly to include the expectation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Created a section in regression tests for benchmarks that test compiler directives. Also, added to basic.toml an expectation tag that will describe if tests are meant to be passed and why they would fail. This will show in the json simulation file.
Related Issue
Motivation and Context
Tests the functionality of compiler directives and reveals bugs.
How Has This Been Tested?
Types of changes
Checklist: