Skip to content

setup gitpod #1078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 9 commits into from
Closed

setup gitpod #1078

wants to merge 9 commits into from

Conversation

luk036
Copy link
Contributor

@luk036 luk036 commented Jan 23, 2020

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Types of changes

  • Bug fix (change which fixes an issue)
  • New feature (change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

ImgBotApp and others added 8 commits December 28, 2019 11:32
@ImgBotApp
[ImgBot] Optimize images
e391267 
*Total -- 4,114.18kb -> 3,300.52kb (19.78%)

/libs/EXTERNAL/capnproto/doc/images/bg_hr.png -- 0.92kb -> 0.30kb (67.23%)
/libs/EXTERNAL/capnproto/doc/images/icon_download.png -- 1.13kb -> 0.43kb (62.31%)
/doc/src/arch/complete_example.png -- 30.16kb -> 12.25kb (59.4%)
/doc/src/arch/channel_distribution.png -- 45.13kb -> 18.57kb (58.86%)
/doc/src/arch/sb_pattern.png -- 83.98kb -> 34.65kb (58.75%)
/libs/EXTERNAL/capnproto/doc/images/twitter.svg -- 2.37kb -> 1.09kb (53.85%)
/blifexplorer/src/images/nodeTypes/module.png -- 1.32kb -> 0.62kb (53.01%)
/libs/EXTERNAL/capnproto/doc/images/blacktocat.png -- 1.39kb -> 0.68kb (51.33%)
/doc/src/vpr/fpga_coordinate_system.png -- 59.87kb -> 29.85kb (50.15%)
/doc/src/vpr/path_2.png -- 10.30kb -> 5.46kb (46.97%)
/doc/src/arch/ipin_diagram.png -- 18.74kb -> 10.30kb (45.04%)
/doc/src/tutorials/arch/timing_modeling/dff.svg -- 25.72kb -> 15.94kb (38.02%)
/doc/src/tutorials/arch/timing_modeling/fa.svg -- 27.51kb -> 17.06kb (37.99%)
/doc/src/arch/wireconn_num_conns_type_min.svg -- 34.77kb -> 21.79kb (37.32%)
/doc/src/arch/wireconn_num_conns_type_from.svg -- 35.28kb -> 22.20kb (37.07%)
/doc/src/arch/wireconn_num_conns_type_to.svg -- 35.77kb -> 22.53kb (37.03%)
/doc/src/tutorials/arch/timing_modeling/mixed_sp_ram.svg -- 31.48kb -> 19.90kb (36.78%)
/doc/src/arch/wireconn_num_conns_type_max.svg -- 39.25kb -> 24.87kb (36.64%)
/doc/src/tutorials/arch/timing_modeling/seq_comb_sp_ram.svg -- 31.70kb -> 20.13kb (36.51%)
/doc/src/tutorials/arch/timing_modeling/seq_sp_ram.svg -- 32.91kb -> 20.92kb (36.42%)
/doc/src/arch/sb_types.svg -- 11.29kb -> 7.21kb (36.17%)
/doc/src/tutorials/arch/timing_modeling/multiclock_dp_ram.svg -- 35.79kb -> 22.95kb (35.86%)
/doc/src/arch/sb_locations.svg -- 123.66kb -> 80.43kb (34.96%)
/doc/src/arch/switch_point_diagram.png -- 7.52kb -> 4.92kb (34.49%)
/libs/EXTERNAL/capnproto/doc/images/capnp-vs-thrift-vs-ice.png -- 8.38kb -> 5.56kb (33.62%)
/libs/EXTERNAL/capnproto/doc/images/capnp-vs-ice.png -- 7.10kb -> 4.86kb (31.66%)
/doc/src/arch/perimeter_fpga_grid.svg -- 33.16kb -> 22.85kb (31.08%)
/doc/src/arch/fill_fpga_grid.svg -- 35.64kb -> 24.66kb (30.8%)
/doc/src/arch/corners_fpga_grid.svg -- 32.79kb -> 22.80kb (30.48%)
/doc/src/arch/fpga_grid_example.svg -- 36.91kb -> 25.67kb (30.46%)
/doc/src/arch/blank_fpga_grid.svg -- 32.53kb -> 22.67kb (30.29%)
/doc/src/arch/row_fpga_grid.svg -- 39.84kb -> 27.80kb (30.23%)
/doc/src/arch/single_fpga_grid.svg -- 32.68kb -> 22.87kb (30%)
/doc/src/arch/col_perim_fpga_grid.svg -- 36.28kb -> 25.47kb (29.8%)
/doc/src/arch/region_incr_fpga_grid.svg -- 34.11kb -> 24.00kb (29.65%)
/doc/src/arch/region_incr_mesh_fpga_grid.svg -- 34.94kb -> 24.67kb (29.38%)
/doc/src/arch/region_single_fpga_grid.svg -- 35.24kb -> 24.89kb (29.37%)
/doc/src/arch/col_fpga_grid.svg -- 36.63kb -> 26.00kb (29.01%)
/doc/src/arch/region_repeat_fpga_grid.svg -- 39.16kb -> 28.00kb (28.5%)
/blifexplorer/src/images/nodeTypes/NOR.png -- 1.99kb -> 1.42kb (28.45%)
/blifexplorer/src/images/nodeTypes/OR.png -- 1.81kb -> 1.31kb (27.43%)
/doc/src/vtr/vtr_task_fig.svg -- 248.12kb -> 180.97kb (27.07%)
/libs/EXTERNAL/capnproto/doc/images/infinity-times-faster.png -- 17.42kb -> 13.21kb (24.14%)
/doc/src/vtr/vtr_flow_fig.svg -- 328.61kb -> 253.14kb (22.97%)
/doc/src/tutorials/timing_simulation/timing_simulation.png -- 55.19kb -> 43.69kb (20.84%)
/doc/src/arch/mux_example.png -- 10.64kb -> 8.48kb (20.34%)
/doc/src/arch/pack_pattern_example.png -- 59.84kb -> 47.69kb (20.3%)
/doc/src/arch/direct_example.png -- 10.75kb -> 8.70kb (19.06%)
/blifexplorer/src/images/nodeTypes/XNOR.png -- 1.82kb -> 1.47kb (18.99%)
/blifexplorer/src/images/nodeTypes/NAND.png -- 1.33kb -> 1.08kb (18.52%)
/libs/EXTERNAL/capnproto/doc/images/time-travel.png -- 29.01kb -> 23.66kb (18.46%)
/blifexplorer/src/images/nodeTypes/CARRY_FUNC.png -- 1.68kb -> 1.39kb (17.29%)
/libs/EXTERNAL/capnproto/doc/images/gittip15.png -- 1.15kb -> 0.97kb (15.42%)
/libs/EXTERNAL/capnproto/doc/slides-2017.05.18/3ph-redirect.png -- 151.65kb -> 129.11kb (14.86%)
/libs/EXTERNAL/capnproto/doc/slides-2017.05.18/3ph-0rt.png -- 152.10kb -> 129.89kb (14.61%)
/libs/EXTERNAL/capnproto/doc/slides-2017.05.18/3ph.png -- 168.99kb -> 144.84kb (14.29%)
/libs/EXTERNAL/capnproto/doc/slides-2017.05.18/3ph-proxy.png -- 165.85kb -> 143.37kb (13.55%)
/libs/EXTERNAL/capnproto/doc/images/logo.png -- 60.78kb -> 53.08kb (12.66%)
/blifexplorer/src/images/nodeTypes/XOR.png -- 1.58kb -> 1.38kb (12.64%)
/vtr_flow/benchmarks/arithmetic/multless_consts/verilog/synth/tests/test1.png -- 21.91kb -> 19.28kb (12.01%)
/blifexplorer/src/images/nodeTypes/Hminus.png -- 0.97kb -> 0.86kb (10.98%)
/blifexplorer/src/images/nodeTypes/AND.png -- 1.18kb -> 1.06kb (10.27%)
/doc/src/vtr/power_estimation/power_flow.svg -- 330.33kb -> 298.00kb (9.79%)
/libs/EXTERNAL/capnproto/doc/images/infinitely_faster.png -- 15.75kb -> 14.22kb (9.73%)
/doc/src/vtr/power_estimation/power_local_interconnect.svg -- 153.70kb -> 142.95kb (6.99%)
/blifexplorer/src/images/nodeTypes/Hadd.png -- 0.94kb -> 0.87kb (6.89%)
/blifexplorer/src/images/nodeTypes/ADDER_FUNC.png -- 0.64kb -> 0.61kb (4.75%)
/doc/src/tutorials/arch/configurable_memory.jpg -- 67.05kb -> 64.13kb (4.35%)
/doc/src/tutorials/arch/configurable_block_ram_routing.jpg -- 76.51kb -> 73.41kb (4.05%)
/doc/src/tutorials/arch/configurable_memory_modes.jpg -- 45.02kb -> 43.20kb (4.03%)
/blifexplorer/src/images/nodeTypes/Hmemory.png -- 0.91kb -> 0.87kb (3.98%)
/doc/src/tutorials/arch/fracturable_multiplier_slice.jpg -- 50.68kb -> 48.67kb (3.95%)
/doc/src/vtr/power_estimation/power_sample_clb.svg -- 25.94kb -> 24.93kb (3.91%)
/blifexplorer/src/images/icon.png -- 1.18kb -> 1.13kb (3.9%)
/doc/src/tutorials/arch/fracturable_multiplier_cluster.jpg -- 61.68kb -> 59.34kb (3.79%)
/doc/src/tutorials/arch/soft_logic_cluster.jpg -- 75.95kb -> 73.28kb (3.53%)
/doc/src/tutorials/arch/fracturable_multiplier.jpg -- 73.17kb -> 70.83kb (3.2%)
/doc/src/tutorials/arch/classic_ble.jpg -- 30.17kb -> 29.23kb (3.13%)
/doc/src/vtr/power_estimation/power_clock_network.svg -- 59.85kb -> 58.04kb (3.03%)
/doc/src/tutorials/arch/v6_logic_slice.jpg -- 116.15kb -> 112.76kb (2.91%)
/blifexplorer/src/images/nodeTypes/Hmult.png -- 1.05kb -> 1.02kb (2.79%)
/doc/src/vtr/power_estimation/power_sb.svg -- 59.27kb -> 57.93kb (2.27%)
/doc/src/vtr/power_estimation/power_cb.svg -- 84.93kb -> 83.04kb (2.23%)
/doc/src/vtr/power_estimation/power_local_interconnect_wirelength.svg -- 69.19kb -> 68.01kb (1.71%)
/libs/EXTERNAL/capnproto/doc/images/sprite_download.png -- 16.41kb -> 16.19kb (1.29%)

Signed-off-by: ImgBotApp <[email protected]>
@luk036
Merge pull request #1 from Loksu/imgbot
95a0bfa 
[ImgBot] Optimize images
@luk036
fixed performance using clang-tidy
ec95699
@luk036
Merge branch 'master' of https://github.com/Loksu/vtr-verilog-to-routing
7b5eab5
@luk036
fix redundant string init and cstr by clang-tidy
5ee1d2f
@luk036
fix by clang-format
ff11b78
@luk036
fix clang-format check problem
5d5d3f4
@luk036
setup gitpod
3db54eb
@probot-autolabeler probot-autolabeler bot added ABC ABC Logic Optimization & Technology Mapping Tool blifexplorer build Build system docs Documentation lang-cpp C/C++ code lang-make CMake/Make code Odin Odin II Logic Synthesis Tool: Unsorted item labels Jan 23, 2020
@mithro
Copy link
Contributor

mithro commented Jan 23, 2020

@luk036 - I think this should probably be split into three separate pull requests;

  • image optimization pull request
  • clang-tidy / clang-format fixes
  • gitpod configuration

You should also provide a description of why someone would want gitpod support in your pull request.

Would you give that a go?

@luk036
Copy link
Contributor Author

luk036 commented Jan 23, 2020 via email

This was referenced Jun 3, 2021
Merged
Open
@mithro
Copy link
Contributor

mithro commented Jun 3, 2021

Hi @luk036,

I have rebase the changes in this pull request onto the latest master and pushed them to two new pull requests. See;

If you want to pick up and continue work on these of these pull requests, it would be very welcome! Otherwise, we will try to find the time to finish fixing them up and getting them merged.

As these two new pull requests exist, I'm closing this one.

Thanks for your contribution!

Tim '@mithro' Ansell

@mithro mithro closed this Jun 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ABC ABC Logic Optimization & Technology Mapping Tool blifexplorer build Build system docs Documentation lang-cpp C/C++ code lang-make CMake/Make code Odin Odin II Logic Synthesis Tool: Unsorted item
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@luk036 @mithro @ImgBotApp