Skip to content

Remove is_remapped flag from rr-edges #2334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vaughnbetz opened this issue Jun 8, 2023 · 1 comment
Closed

Remove is_remapped flag from rr-edges #2334

vaughnbetz opened this issue Jun 8, 2023 · 1 comment
Assignees

Comments

@vaughnbetz
Copy link
Contributor

This flag is on every rr-edge, which is wasteful. It is really providing some high level control functionality only during rr-graph building.

Best solution if possible: have the control code decide whether or not to remap some/all switches, with no storage.

If not possible, put an unordered_set in the rr_graph_builder object so we only temporarily have this storage. Set the flag only if we need to remap something. Could alternatively put it in a bool vector [0..num_rr_edges-1].

@amin1377
Copy link
Contributor

amin1377 commented Jul 7, 2023

This issue is addressed in this pull request. The flag cannot be removed because, when flat routing is enabled, remapping on edges is performed twice. Therefore, we require a way to identify the edges that have already been remapped. Otherwise, we may encounter a situation where an edge is remapped twice. However, this variable is only needed during construction of the RR (Routing Resource) graph. Consequently, I have deleted the vector that stores this variable once the RR graph is built.

@amin1377 amin1377 closed this as completed Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants