Skip to content

Changes by PaulZC #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 25, 2020
Merged

Changes by PaulZC #1

merged 1 commit into from
Jul 25, 2020

Conversation

PaulZC
Copy link

@PaulZC PaulZC commented Jul 25, 2020

Hi @unsurv,
Thanks again for submitting your PR sparkfun#116. It was good but needed a few corrections. If you merge this PR into your master branch, we can then get PR sparkfun#116 merged into the main SparkFun master branch.
The changes are:

  • Added definitions for the four wakeupSources pins so they can be or'd together if necessary
  • Changed wakeupPin (uint8_t) to wakeupSources (uint32_t) in powerOffWithInterrupt
  • Changed the spaces to tabs in keywords.txt
  • Added payloadCfg[4-7] to powerOff. It is important that these get set correctly.
  • Added payloadCfg[1-3] to powerOffWithInterrupt. It is important these are set to zero and not left undefined.
  • Corrected the order of payloadCfg[8-11] in powerOffWithInterrupt. These were big endian but need to be little endian.
  • Corrected the value for payloadCfg[8] when forceWhileUSB is true (needs to be 0x06 not 0x04).
  • Set payloadCfg[12-15] in powerOffWithInterrupt according to wakeupSources.
    All the best,
    Paul

@unsurv
Copy link
Owner

unsurv commented Jul 25, 2020

Thanks for fixing these.

@unsurv unsurv merged commit 8c8ee4b into unsurv:master Jul 25, 2020
@PaulZC PaulZC deleted the Changes_to_PR_#116 branch July 25, 2020 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants