Skip to content

Add images submenu functionality and notification displays #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Sep 21, 2021

Conversation

unixorn
Copy link
Owner

@unixorn unixorn commented Sep 19, 2021

Description

  • Use Apple's Notification Manager (via osascript) to display notifications about some of our long-running tasks
    • Add displayAlert() for failure notifications so it doesn't disappear
    • Add displayNotification() that uses the macOS Notification Manager
    • Add notifications to image pull and remove operations
    • Add notifications to VM start/stop
  • Add functionality to the image submenus
    • We now can pull or remove images from the lima menu
  • Updated dependency checks
    • Add check for lima in $PATH
    • Add check for osascript in $PATH
  • Makefile improvements
    • make i now runs shellcheck first

Type of changes

Checklist

  • All new and existing tests pass.
  • Any scripts added use #!/usr/bin/env interpreter instead of potentially platform-specific direct paths (#!/bin/sh and #!/bin/bash are allowed exceptions)
  • Scripts are marked executable
  • Scripts do not have a language file extension unless they are meant to be sourced and not run standalone. No one should have to know if a script was written in bash, python, ruby or whatever. Not including file extensions makes it easier to rewrite the script in another language later without having to change every reference to the previous version.
  • I have confirmed that the link(s) in my PR are valid.

License Acceptance

  • This repository is Apache version 2.0 licensed (some scripts may have alternate licensing inline in their code) and by making this PR, I am contributing my changes to the repository under the terms of the Apache 2 license.

- Add submenu that shows all the images loaded in a given Lima VM

Signed-off-by: Joe Block <[email protected]>
Signed-off-by: Joe Block <[email protected]>
Yes, it'll be installed on macOS, but if the user has played games with
their `$PATH`, the plugin may not be able to find it.

Signed-off-by: Joe Block <[email protected]>
- Add `displayAlert()` for failure notifications so it doesn't disappear
- Add `displayNotification()` that uses the macOS Notification Manager
- Add check for `lima` in `$PATH`
- Add notifications to image pull operation
- Add notifications to VM start/stop

Signed-off-by: Joe Block <[email protected]>
@unixorn unixorn changed the title Add submenu functionality and notification displays Add images submenu functionality and notification displays Sep 21, 2021
@unixorn unixorn merged commit 0640d99 into main Sep 21, 2021
@unixorn unixorn deleted the submenus-for-vms branch September 21, 2021 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant