Python rewrite - Enjoy the 50x speedup! #14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Initial poetry setup - Add coverage Signed-off-by: Joe Block <[email protected]>
- Add format and test stanzas to Makefile - Update requirements stanza in Makefile Signed-off-by: Joe Block <[email protected]>
The shell version is too slow. Too many calls to `jq` that weren't cached. Rewrite in python3 for speed and maintainability. Signed-off-by: Joe Block <[email protected]>
Some of our operations like VM starts or image pulls can take a while. Use the notification manager to display notifications before & after we do a lima operation. Signed-off-by: Joe Block <[email protected]>
unixorn
force-pushed
the
python-conversion
branch
from
5d40d3f to
084f61d
Compare
Signed-off-by: Joe Block <[email protected]>
unixorn
force-pushed
the
python-conversion
branch
from
084f61d to
d888caf
Compare
Signed-off-by: Joe Block <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Rewrote in Python, mainly because the
bashwas starting to get too large to work with comfortably, and Python's way more maintainable.On top of that, the original
bashversion was slow, because there were a lot of cases where it was runninglima nerdctl XYZ | jqto parse out information about containers and images, and it wasn't caching thelima nerdctloutput.The Python version caches the image and container information, and is much faster - 0.355 seconds on my MBP, the shell version takes 17.332 seconds.
Closes #7
Closes #8
Checklist
#!/usr/bin/env interpreterinstead of potentially platform-specific direct paths (#!/bin/shand#!/bin/bashare allowed exceptions)bash,python,rubyor whatever. Not including file extensions makes it easier to rewrite the script in another language later without having to change every reference to the previous version.License Acceptance