Skip to content

check if fileActions is null before accessing the property onConfirmClose #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 8, 2021

Conversation

rady-ben
Copy link
Contributor

@rady-ben rady-ben commented Sep 1, 2021

This change is Reviewable

@ancientTexts-net
Copy link
Contributor

ancientTexts-net commented Sep 8, 2021


src/components/application-bar/RepositoryMenu.js, line 48 at r1 (raw file):

      }
    }
  },[actions.close, file, fileActions?.onConfirmClose]);

NOTE: I think this was causing an error in the styleguidist. Fixed. 👍

Copy link
Contributor

@ancientTexts-net ancientTexts-net left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @rady-ben)

@jincypjose jincypjose changed the title check if fileActions is null befor accessing the property onConfirmClose check if fileActions is null before accessing the property onConfirmClose Sep 8, 2021
Copy link
Contributor

@jincypjose jincypjose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @rady-ben)

@ancientTexts-net ancientTexts-net self-requested a review September 8, 2021 15:18
@ancientTexts-net
Copy link
Contributor

ancientTexts-net commented Sep 8, 2021

:lgtm:

@ancientTexts-net ancientTexts-net merged commit 9f6a94a into unfoldingWord:master Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants