Skip to content

Feature 228/add support for more urls #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 3, 2021
Merged

Feature 228/add support for more urls #102

merged 1 commit into from
Aug 3, 2021

Conversation

PhotoNomad0
Copy link
Contributor

@PhotoNomad0 PhotoNomad0 commented Aug 3, 2021 •
edited
Loading

Describe what your pull request addresses

part of unfoldingWord/gateway-edit#228

  • fix to remove coverage calcs from published module

Test Instructions

  • test with https://deploy-preview-265--gateway-edit.netlify.app/
  • try add the following scripture urls to a scripture pane. Make sure scripture actually shows up in scripture pane:
  • https://git.door43.org/unfoldingWord/en_ult
  • https://git.door43.org/unfoldingWord/el-x-koine_ugnt/src/tag/v0.20
  • https://door43.org/u/unfoldingWord/en_ult/
  • https://git.door43.org/Door43-Catalog/en_ust.git
  • [email protected]:unfoldingWord/en_ult.git

This change is Reviewable

@PhotoNomad0 PhotoNomad0 marked this pull request as ready for review August 3, 2021 14:08
@PhotoNomad0 PhotoNomad0 changed the title WIP: feature 228/add support for more urls Feature 228/add support for more urls Aug 3, 2021
@mannycolon mannycolon merged commit a0d73c9 into master Aug 3, 2021
@mannycolon mannycolon deleted the feature-mcleanb-228-supportNewScriptureLinks branch August 3, 2021 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PhotoNomad0 @mannycolon