Apply minimal changes/tweaks to restore a responsive narrow view. #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…view. Playing with disabling the custom CSS we apply lead to discovering that the theme we use already had support for a collapsed sidebar view based on a media query that came into effect at 768px. Arrange applying essentially the same styles at our existing break point of 1100px, remove a couple of conflicting things in our custom CSS and set a handful of basic styles (in line with choices already made in the page) such that the responsive view comes into a working order.
SebastianPrehn
requested review from
SebastianPrehn and
aputtu
and removed request for
aputtu and
SebastianPrehn
SebastianPrehn
approved these changes
Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Playing with disabling the custom CSS we apply lead to discovering that the theme we use already had support for a collapsed sidebar view based on a media query that came into effect at 768px.
Arrange applying essentially the same styles at our existing break point of 1100px, remove a couple of conflicting things in our custom CSS and set a handful of basic styles (in line with choices already made in the page) such that the responsive view comes into a working order.