Skip to content

Commit 91b3952

Browse files
Mikihito Matsuuracopybara-github
Mikihito Matsuura
authored andcommitted
Revert "Reland "[BRP] Enable check_raw_ptr_fields for Windows""
This reverts commit f31d2421e569f10ac298c2cd16ec1cd13835d24a. Reason for revert: Suspected build failure in some env. https://crbug.com/1449812 Original change's description: > Reland "[BRP] Enable check_raw_ptr_fields for Windows" > > This reverts commit 690c844182f9720766ee39d351eca05d52aa8a7d. > > Reason for revert: The build errors should be fixed by the following > change. > https://crrev.com/c/4522366 > > Original change's description: > > Revert "[BRP] Enable check_raw_ptr_fields for Windows" > > > > This reverts commit fb6cdaf4b63c9b8c7a024f023b32283388077b79. > > > > Reason for revert: Suspected of causing build errors > > https://ci.chromium.org/ui/p/chromium/builders/ci/Win%20x64%20Builder/133542/overview > > > > Original change's description: > > > [BRP] Enable check_raw_ptr_fields for Windows > > > > > > Reland after r1132904. > > > I've added a workaround for back slashes and forward slashes getting mixed up on some bots. > > > https://ci.chromium.org/ui/p/chromium/builders/ci/GPU%20Win%20x64%20Builder/55007/overview > > > > > > Bug: 1273182 > > > Change-Id: Ie70ceef02d775dc04a24fd573b733c63238f01c8 > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4457654 > > > Reviewed-by: Takuto Ikuta <[email protected]> > > > Commit-Queue: Keishi Hattori <[email protected]> > > > Cr-Commit-Position: refs/heads/main@{#1136954} > > > > Bug: 1273182 > > Change-Id: I3bdef96cded42f4288082ae7cee7502c89abb373 > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4486581 > > Commit-Queue: Cassy Chun-Crogan <[email protected]> > > Bot-Commit: Rubber Stamper <[email protected]> > > Owners-Override: Cassy Chun-Crogan <[email protected]> > > Reviewed-by: Takuto Ikuta <[email protected]> > > Cr-Commit-Position: refs/heads/main@{#1136958} > > Bug: 1273182 > Change-Id: I5b64e4b0c52fdcb4849920e2a6145188971be6fd > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4554819 > Reviewed-by: Keishi Hattori <[email protected]> > Reviewed-by: Takuto Ikuta <[email protected]> > Commit-Queue: Mikihito Matsuura <[email protected]> > Cr-Commit-Position: refs/heads/main@{#1148996} Bug: 1273182 Change-Id: Ief897b10add2860e3ac974029a306190c3318baf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4573488 Reviewed-by: Takuto Ikuta <[email protected]> Commit-Queue: Mikihito Matsuura <[email protected]> Bot-Commit: Rubber Stamper <[email protected]> Cr-Commit-Position: refs/heads/main@{#1150412} NOKEYCHECK=True GitOrigin-RevId: 2492c170cfeef2a40cb4ac1c69b293523857efc5
1 parent 6cb0fb6 commit 91b3952

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

config/clang/clang.gni

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ declare_args() {
1616

1717
enable_check_raw_ptr_fields =
1818
build_with_chromium && !is_official_build &&
19-
((is_linux && !is_castos) || (is_android && !is_cast_android) || is_win)
19+
((is_linux && !is_castos) || (is_android && !is_cast_android))
2020

2121
clang_base_path = default_clang_base_path
2222

0 commit comments

Comments
 (0)