siso: add rewrapper_to_reproxy config for linux

Bug: b/273407069
Change-Id: Iadbac08d0aa1ca3b48d72858f7d6f5920d2fcb05
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4569976
Reviewed-by: Junji Watanabe <[email protected]>
Commit-Queue: Richard Wang <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1150405}
NOKEYCHECK=True
GitOrigin-RevId: 730d7693d7c054f1d788ac5265e2ee5a983b12d2

Author: rzhw

config/siso/config.star

@@ -6,7 +6,9 @@
 
 load("@builtin//struct.star", "module")
 
-__KNOWN_CONFIG_OPTIONS = []
+__KNOWN_CONFIG_OPTIONS = [
+    "rewrapper_to_reproxy",
+]
 
 def __check(ctx):
     if "config" in ctx.flags:

config/siso/linux.star

@@ -10,6 +10,7 @@ load("./config.star", "config")
 load("./mojo.star", "mojo")
 load("./nacl_linux.star", "nacl")
 load("./remote_exec_wrapper.star", "remote_exec_wrapper")
+load("./rewrapper_to_reproxy.star", "rewrapper_to_reproxy")
 
 __filegroups = {}
 __filegroups.update(clang.filegroups)
@@ -20,6 +21,8 @@ __handlers = {}
 __handlers.update(clang.handlers)
 __handlers.update(mojo.handlers)
 __handlers.update(nacl.handlers)
+__handlers.update(remote_exec_wrapper.handlers)
+__handlers.update(rewrapper_to_reproxy.handlers)
 
 def __step_config(ctx, step_config):
     config.check(ctx)
@@ -29,7 +32,10 @@ def __step_config(ctx, step_config):
             "container-image": "docker://gcr.io/chops-private-images-prod/rbe/siso-chromium/linux@sha256:d4fcda628ebcdb3dd79b166619c56da08d5d7bd43d1a7b1f69734904cc7a1bb2",
         },
     }
-    if remote_exec_wrapper.enabled(ctx):
+    # rewrapper_to_reproxy takes precedence over remote exec wrapper handler if enabled.
+    if rewrapper_to_reproxy.enabled(ctx):
+        step_config = rewrapper_to_reproxy.step_config(ctx, step_config)
+    elif remote_exec_wrapper.enabled(ctx):
         step_config = remote_exec_wrapper.step_config(ctx, step_config)
     else:
         step_config = clang.step_config(ctx, step_config)

config/siso/mac.star

@@ -11,6 +11,7 @@ __filegroups = {}
 __handlers = {}
 
 def __step_config(ctx, step_config):
+    # TODO(b/273407069): Handle reproxy mode.
     config.check(ctx)
     if remote_exec_wrapper.enabled(ctx):
         step_config = remote_exec_wrapper.step_config(ctx, step_config)

config/siso/rewrapper_to_reproxy.star

@@ -0,0 +1,76 @@
+# -*- bazel-starlark -*-
+# Copyright 2023 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+"""Siso configuration for rewriting remote exec wrapper calls into reproxy config."""
+
+load("@builtin//lib/gn.star", "gn")
+load("@builtin//struct.star", "module")
+load("./config.star", "config")
+
+__filegroups = {}
+
+def __remove_rewrapper(ctx, cmd):
+    # Slice from the first non-arg passed to rewrapper.
+    # (Whilst rewrapper usage is `rewrapper [-flags] -- command ...` we don't pass -- to rewrapper.)
+    non_flag_start = -1
+    for i, arg in enumerate(cmd.args):
+        if i == 0:
+            continue
+        if not arg.startswith('-'):
+            non_flag_start = i
+            break
+    if non_flag_start < 1:
+        fail("couldn't find first non-arg passed to rewrapper")
+    ctx.actions.fix(
+        args = cmd.args[non_flag_start:],
+    )
+
+__handlers = {
+    "remove_rewrapper": __remove_rewrapper,
+}
+
+def __enabled(ctx):
+    if config.get(ctx, "rewrapper_to_reproxy") and "args.gn" in ctx.metadata:
+        gn_args = gn.parse_args(ctx.metadata["args.gn"])
+        if gn_args.get("use_remoteexec") == "true":
+            return True
+    return False
+
+def __step_config(ctx, step_config):
+    # TODO(b/273407069): Read reproxy config from config files.
+    step_config["rules"].extend([
+        {
+            "name": "clang/cxx",
+            "action": "(.*_)?cxx",
+            "handler": "remove_rewrapper",
+            "reproxy_config": {"labels": {"type": "compile", "compiler": "clang", "lang": "cpp"}},
+        },
+        {
+            "name": "clang/cc",
+            "action": "(.*_)?cc",
+            "handler": "remove_rewrapper",
+            "reproxy_config": {"labels": {"type": "compile", "compiler": "clang", "lang": "cpp"}},
+        },
+        {
+            "name": "clang/objcxx",
+            "action": "(.*_)?objcxx",
+            "handler": "remove_rewrapper",
+            "reproxy_config": {"labels": {"type": "compile", "compiler": "clang", "lang": "cpp"}},
+        },
+        {
+            "name": "clang/objc",
+            "action": "(.*_)?objc",
+            "handler": "remove_rewrapper",
+            "reproxy_config": {"labels": {"type": "compile", "compiler": "clang", "lang": "cpp"}},
+        },
+    ])
+    return step_config
+
+rewrapper_to_reproxy = module(
+    "rewrapper_to_reproxy",
+    enabled = __enabled,
+    step_config = __step_config,
+    filegroups = __filegroups,
+    handlers = __handlers,
+)

config/siso/windows.star

@@ -11,6 +11,7 @@ __filegroups = {}
 __handlers = {}
 
 def __step_config(ctx, step_config):
+    # TODO(b/273407069): Handle reproxy mode.
     config.check(ctx)
     if remote_exec_wrapper.enabled(ctx):
         step_config = remote_exec_wrapper.step_config(ctx, step_config)