Skip to content

Add an option to mount .ssh directory of current user #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 28, 2019

Conversation

mprzytulski
Copy link
Contributor

@mprzytulski mprzytulski commented Aug 10, 2017

A useful thing when you need to clone private repositories as a dependency.

@ubaniabalogun
Copy link
Owner

Hey @mprzytulski,
Thanks for the PR!
Can you please provide more details on what this does and how I can test it?

@mprzytulski
Copy link
Contributor Author

mprzytulski commented Aug 14, 2017

Hi @ubaniabalogun, hope those details will help you:

Use case:
Install dependency from private repository as a part of package process

Problem:
Private repository requires ssh key for cloning - we can create a new docker image with key, but it's a bit of overkill

Proposed solution:
Allow mounting .ssh directory which contains ssh keys which can be used for authentication

Implementation:
New option mountSSH has been added to a configuration which will change docker run parameters and mount current user home directory under docker root user .ssh folder.

Testing:
Add any private git repository as a dependency of the function

veriservus and others added 2 commits August 14, 2017 10:06
If there is a runtime specified
@ubaniabalogun
Copy link
Owner

Hey @mprzytulski,

I'm still working on testing this. Unfortunately, I've been getting errors when trying to clone a private repository with the useDocker flag set.

What URL scheme are you using when adding a private repository as a dependency for functions?
Do you have a test project I can use to validate the PR?
Thanks,

@ubaniabalogun ubaniabalogun merged commit f4838f7 into ubaniabalogun:master Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants