Skip to content

chore(type-utils): remove getTypeArguments #8938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

y-hsgw
Copy link
Contributor

@y-hsgw y-hsgw commented Apr 17, 2024

BREAKING CHANGE:
Removes an exported function.

PR Checklist

Overview

Removed deprecated getTypeArguments from type-utils.

JoshuaKGoldberg and others added 3 commits April 15, 2024 10:56
…typescript-eslint#8834)

* feat(typescript-estree): remove slow deprecated and isolated programs

* Update packages/typescript-estree/src/create-program/createProjectProgram.ts

Co-authored-by: Brad Zacher <[email protected]>

---------

Co-authored-by: Brad Zacher <[email protected]>
typescript-eslint#8920)

* fix(typescript-estree): add TSEnumBody node for TSEnumDeclaration body

* Fixed up tests and their snapshots

* More about enums

* Indent too

* Update packages/ast-spec/src/special/TSEnumBody/spec.ts

Co-authored-by: Brad Zacher <[email protected]>

* parent types touchups

* Update packages/visitor-keys/src/visitor-keys.ts

Co-authored-by: Brad Zacher <[email protected]>

---------

Co-authored-by: Brad Zacher <[email protected]>
@typescript-eslint
Copy link
Contributor

Thanks for the PR, @y-hsgw!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@y-hsgw y-hsgw changed the title feat(type-utils): Remove getTypeArguments feat(type-utils): remove getTypeArguments Apr 17, 2024
@y-hsgw y-hsgw changed the title feat(type-utils): remove getTypeArguments chore(type-utils): remove getTypeArguments Apr 17, 2024
@auvred auvred added the breaking change This change will require a new major version to be released label Apr 19, 2024
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks! 🙌

@JoshuaKGoldberg JoshuaKGoldberg merged commit bea2e44 into typescript-eslint:v8 Apr 22, 2024
4 checks passed
@y-hsgw y-hsgw deleted the remove-get-type-arguments branch April 23, 2024 00:46
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
breaking change This change will require a new major version to be released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants