-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
fix(eslint-plugin): [brace-style] handle enum declarations #1281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(eslint-plugin): [brace-style] handle enum declarations #1281
Conversation
Thanks for the PR, @a-tarasyuk! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day. |
Codecov Report
@@ Coverage Diff @@
## master #1281 +/- ##
==========================================
+ Coverage 93.93% 94.06% +0.13%
==========================================
Files 131 131
Lines 5804 5781 -23
Branches 1639 1630 -9
==========================================
- Hits 5452 5438 -14
+ Misses 188 184 -4
+ Partials 164 159 -5
|
How come you chose to reimplement the rule logic instead of using the old monkey patch? |
@bradzacher monkey patching is good., If this PR doesn't make sense I'm OK to close it. |
No, it's all good - I didn't realise that the enum ast node didn't have a body, sorry. Your approach is correct, given the lack of a body. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks for this
Thank you! |
Fixes #1274