Skip to content

fix(scope-manager): add a reference for JSX closing element if it exists #10614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

ronami
Copy link
Member

@ronami ronami commented Jan 5, 2025

PR Checklist

Overview

Addresses #9790 and registers a reference for the closing JSX element if it exists.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @ronami!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlify bot commented Jan 5, 2025

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit d20803a
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/677ab9da25e6990008683c20
😎 Deploy Preview https://deploy-preview-10614--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (🟢 up 9 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

nx-cloud bot commented Jan 5, 2025

View your CI Pipeline Execution ↗ for commit d20803a.

Command Status Duration Result
nx run-many --target=build --exclude website --... ✅ Succeeded 6s View ↗
nx run-many --target=clean ✅ Succeeded 10s View ↗

☁️ Nx Cloud last updated this comment at 2025-01-07 13:42:25 UTC

Copy link

codecov bot commented Jan 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.91%. Comparing base (c7154bf) to head (d20803a).
Report is 34 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10614   +/-   ##
=======================================
  Coverage   86.90%   86.91%           
=======================================
  Files         446      446           
  Lines       15508    15510    +2     
  Branches     4518     4518           
=======================================
+ Hits        13478    13480    +2     
  Misses       1675     1675           
  Partials      355      355           
Flag Coverage Δ
unittest 86.91% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ackages/scope-manager/src/referencer/Referencer.ts 97.20% <100.00%> (+0.02%) ⬆️

@ronami ronami marked this pull request as ready for review January 5, 2025 17:16
@ronami ronami marked this pull request as draft January 5, 2025 17:17
@ronami ronami marked this pull request as ready for review January 5, 2025 17:30
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM, but scope management can be surprisingly tricky. We should get another review.

@JoshuaKGoldberg JoshuaKGoldberg added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Jan 7, 2025
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok it's been 2 weeks of ✅ + passing CI and I've scrutinized this a whole bunch. I'll just merge now.

Cheers!

@JoshuaKGoldberg JoshuaKGoldberg merged commit 57c7bed into typescript-eslint:main Jan 19, 2025
64 checks passed
@ronami ronami deleted the scope-manager-reference-closing-jsx-element branch January 19, 2025 17:03
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Scope API can't get reference in JSX closing element
2 participants