-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
fix(scope-manager): add a reference for JSX closing element if it exists #10614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(scope-manager): add a reference for JSX closing element if it exists #10614
Conversation
Thanks for the PR, @ronami! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
View your CI Pipeline Execution ↗ for commit d20803a.
☁️ Nx Cloud last updated this comment at |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10614 +/- ##
=======================================
Coverage 86.90% 86.91%
=======================================
Files 446 446
Lines 15508 15510 +2
Branches 4518 4518
=======================================
+ Hits 13478 13480 +2
Misses 1675 1675
Partials 355 355
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 LGTM, but scope management can be surprisingly tricky. We should get another review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok it's been 2 weeks of ✅ + passing CI and I've scrutinized this a whole bunch. I'll just merge now.
Cheers!
PR Checklist
Overview
Addresses #9790 and registers a reference for the closing JSX element if it exists.