fix(eslint-plugin): [use-unknown-in-catch-callback-variable] only flag function literals

[kirkwaiblinger]

PR Checklist

• Addresses an existing open issue: fixes Enhancement: [use-unknown-in-catch-callback-variable] Option to only check inline functions #9057
• That issue was marked as accepting prs
• Steps in Contributing were taken

Overview

Since we're no longer generally flagging expressions that have type (e: any) => whatever, I added in recursion to catch function literals not passed directly, but whose type is still inferred. So, promise.catch(condition ? (e) => {} : (e) => {}); still can and does trigger the rule, since e is inferred as any in both locations. Plus, the rule reports them each individually and consequently offers a suggestion now.

[typescript-eslint]

Thanks for the PR, @kirkwaiblinger!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

---

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

[netlify]

✅ Deploy Preview for typescript-eslint ready!

Name	Link
🔨 Latest commit	71b7616
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/675702201165fb000839c4e9
😎 Deploy Preview	https://deploy-preview-10436--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 93 (🟢 up 1 from production) Accessibility: 100 (no change from production) Best Practices: 92 (no change from production) SEO: 98 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 71b7616. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

---

✅ Successfully ran 2 targets

• nx run-many --target=build --exclude website --exclude website-eslint
• nx run-many --target=clean

---

Sent with 💌 from NxCloud.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.76%. Comparing base (05617d2) to head (71b7616).
Report is 23 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #10436   +/-   ##
=======================================
  Coverage   86.75%   86.76%           
=======================================
  Files         443      444    +1     
  Lines       15302    15340   +38     
  Branches     4454     4467   +13     
=======================================
+ Hits        13276    13310   +34     
- Misses       1672     1675    +3     
- Partials      354      355    +1     

Flag	Coverage Δ
unittest	86.76% <100.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...rc/rules/use-unknown-in-catch-callback-variable.ts	97.53% <100.00%> (-2.47%)	⬇️

... and 7 files with indirect coverage changes

[JoshuaKGoldberg]

Wow this is so much more effort than I thought would happen - and it's a great improvement! 🔥