fix(eslint-plugin): [no-unsafe-return] don't reiterate through all type parts for each part

[tezf]

PR Checklist

• Addresses an existing open issue: fixes Performance degradation in 8.1.0: @typescript-eslint/no-unsafe-return with high-cardinality unions #10196
• That issue was marked as accepting prs
• Steps in Contributing were taken

Overview

Prevents the whole type from being looped through isThenableType once for each part of the type.

[typescript-eslint]

Thanks for the PR, @tezf!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

---

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

[netlify]

✅ Deploy Preview for typescript-eslint ready!

Name	Link
🔨 Latest commit	a704014
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/6719e97a664eea0008a98646
😎 Deploy Preview	https://deploy-preview-10203--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 99 (🟢 up 5 from production) Accessibility: 100 (no change from production) Best Practices: 92 (no change from production) SEO: 98 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit a704014. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

---

✅ Successfully ran 2 targets

• nx run-many --target=build --exclude website --exclude website-eslint
• nx run-many --target=clean

---

Sent with 💌 from NxCloud.

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 86.18%. Comparing base (a744765) to head (a704014).
Report is 4 commits behind head on main.

Files with missing lines	Patch %	Lines
packages/type-utils/src/predicates.ts	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #10203      +/-   ##
==========================================
+ Coverage   86.16%   86.18%   +0.02%     
==========================================
  Files         430      430              
  Lines       15031    15055      +24     
  Branches     4361     4368       +7     
==========================================
+ Hits        12951    12975      +24     
  Misses       1728     1728              
  Partials      352      352              

Flag	Coverage Δ
unittest	86.18% <0.00%> (+0.02%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
packages/type-utils/src/predicates.ts	21.21% <0.00%> (ø)

[JoshuaKGoldberg]

Oh! Nice catch 👏

[kirkwaiblinger]

Looks good to me as well. Just wondering if there's a way to regression test for this?

[bradzacher]

Thanks for fixing this!