Feature/convert editor settings 133

jest.config.js

@@ -5,6 +5,7 @@ module.exports = {
         "!./src/**/*.stubs.ts",
         "!./src/adapters/*.ts",
         "!./src/rules/converters.ts",
+        "!./src/settings/converters.ts",
         "!./src/rules/mergers.ts",
         "!./src/cli/main.ts",
     ],

src/adapters/fileSystem.stub.ts

@@ -0,0 +1,11 @@
+export const createStubFileSystem = ({ data = {}, exists = true } = {}) => ({
+    fileExists: jest.fn().mockReturnValue(exists),
+    readFile: jest.fn().mockReturnValue(Promise.resolve(data)),
+    writeFile: jest.fn(),
+});
+
+export const createStubThrowingFileSystem = ({ err = "" } = {}) => ({
+    fileExists: jest.fn().mockRejectedValue(Promise.resolve(new Error(err))),
+    readFile: jest.fn().mockRejectedValue(Promise.resolve(new Error(err))),
+    writeFile: jest.fn().mockRejectedValue(Promise.resolve(new Error(err))),
+});

src/cli/main.ts

@@ -6,6 +6,10 @@ import { nativeImporter } from "../adapters/nativeImporter";
 import { processLogger } from "../adapters/processLogger";
 import { bind } from "../binding";
 import { ConvertConfigDependencies, convertConfig } from "../conversion/convertConfig";
+import {
+    ConvertEditorConfigDependencies,
+    convertEditorConfig,
+} from "../conversion/convertEditorConfig";
 import { removeExtendsDuplicatedRules } from "../creation/simplification/removeExtendsDuplicatedRules";
 import {
     RetrieveExtendsValuesDependencies,
@@ -19,6 +23,7 @@ import {
     writeConversionResults,
     WriteConversionResultsDependencies,
 } from "../creation/writeConversionResults";
+import { writeConversionResults as writeEditorConfigConversionResults } from "../creation/writeEditorConfigConversionResults";
 import {
     findOriginalConfigurations,
     FindOriginalConfigurationsDependencies,
@@ -27,22 +32,28 @@ import { findPackagesConfiguration } from "../input/findPackagesConfiguration";
 import { findESLintConfiguration } from "../input/findESLintConfiguration";
 import { findTSLintConfiguration } from "../input/findTSLintConfiguration";
 import { findTypeScriptConfiguration } from "../input/findTypeScriptConfiguration";
+import { findEditorConfiguration } from "../input/findEditorConfiguration";
 import { importer, ImporterDependencies } from "../input/importer";
 import { mergeLintConfigurations } from "../input/mergeLintConfigurations";
-import {
-    reportConversionResults,
-    ReportConversionResultsDependencies,
-} from "../reporting/reportConversionResults";
-import { converters } from "../rules/converters";
+import { reportSettingConversionResults } from "../reporting/reportSettingConversionResults";
+import { reportConversionResults } from "../reporting/reportConversionResults";
+import { ReportConversionResultsDependencies } from "../reporting/dependencies";
+import { converters as rulesConverters } from "../rules/converters";
+import { converters as settingsConverters } from "../settings/converters";
 import { convertRules } from "../rules/convertRules";
 import { mergers } from "../rules/mergers";
 import { runCli, RunCliDependencies } from "./runCli";
+import { convertSettings } from "../settings/convertSettings";
 
 const convertRulesDependencies = {
-    converters,
+    converters: rulesConverters,
     mergers,
 };
 
+const convertSettingsDependencies = {
+    converters: settingsConverters,
+};
+
 const nativeImporterDependencies: ImporterDependencies = {
     fileSystem: fsFileSystem,
     getCwd: () => process.cwd(),
@@ -56,6 +67,10 @@ const findConfigurationDependencies = {
     importer: boundImporter,
 };
 
+const findEditorConfigurationDependencies = {
+    fileSystem: fsFileSystem,
+};
+
 const findOriginalConfigurationsDependencies: FindOriginalConfigurationsDependencies = {
     findESLintConfiguration: bind(findESLintConfiguration, findConfigurationDependencies),
     findPackagesConfiguration: bind(findPackagesConfiguration, findConfigurationDependencies),
@@ -81,6 +96,19 @@ const writeConversionResultsDependencies: WriteConversionResultsDependencies = {
     fileSystem: fsFileSystem,
 };
 
+const convertEditorConfigDependencies: ConvertEditorConfigDependencies = {
+    convertSettings: bind(convertSettings, convertSettingsDependencies),
+    findEditorConfiguration: bind(findEditorConfiguration, findEditorConfigurationDependencies),
+    reportConversionResults: bind(
+        reportSettingConversionResults,
+        reportConversionResultsDependencies,
+    ),
+    writeConversionResults: bind(
+        writeEditorConfigConversionResults,
+        writeConversionResultsDependencies,
+    ),
+};
+
 const convertConfigDependencies: ConvertConfigDependencies = {
     convertRules: bind(convertRules, convertRulesDependencies),
     findOriginalConfigurations: bind(
@@ -93,7 +121,10 @@ const convertConfigDependencies: ConvertConfigDependencies = {
 };
 
 const runCliDependencies: RunCliDependencies = {
-    convertConfig: bind(convertConfig, convertConfigDependencies),
+    convertConfigs: [
+        bind(convertConfig, convertConfigDependencies),
+        bind(convertEditorConfig, convertEditorConfigDependencies),
+    ],
     logger: processLogger,
 };
 

src/cli/runCli.test.ts

@@ -8,9 +8,11 @@ import { runCli, RunCliDependencies } from "./runCli";
 const createStubArgv = (argv: string[] = []) => ["node", "some/path/bin/file", ...argv];
 
 const createStubRunCliDependencies = (
-    overrides: Partial<Pick<RunCliDependencies, "convertConfig">> = {},
+    overrides: Partial<Pick<RunCliDependencies, "convertConfigs">> = {},
 ) => ({
-    convertConfig: async (): Promise<TSLintToESLintResult> => ({ status: ResultStatus.Succeeded }),
+    convertConfigs: [
+        async (): Promise<TSLintToESLintResult> => ({ status: ResultStatus.Succeeded }),
+    ],
     logger: createStubLogger(),
     ...overrides,
 });
@@ -32,7 +34,7 @@ describe("runCli", () => {
         // Arrange
         const message = "Oh no";
         const dependencies = createStubRunCliDependencies({
-            convertConfig: () => Promise.reject(new Error(message)),
+            convertConfigs: [() => Promise.reject(new Error(message))],
         });
 
         // Act
@@ -49,11 +51,13 @@ describe("runCli", () => {
         // Arrange
         const complaint = "too much unit testing coverage";
         const dependencies = createStubRunCliDependencies({
-            convertConfig: () =>
-                Promise.resolve({
-                    complaints: [complaint],
-                    status: ResultStatus.ConfigurationError,
-                }),
+            convertConfigs: [
+                () =>
+                    Promise.resolve({
+                        complaints: [complaint],
+                        status: ResultStatus.ConfigurationError,
+                    }),
+            ],
         });
 
         // Act
@@ -72,11 +76,13 @@ describe("runCli", () => {
         // Arrange
         const error = new Error("too much unit testing coverage");
         const dependencies = createStubRunCliDependencies({
-            convertConfig: () =>
-                Promise.resolve({
-                    errors: [error],
-                    status: ResultStatus.Failed,
-                }),
+            convertConfigs: [
+                () =>
+                    Promise.resolve({
+                        errors: [error],
+                        status: ResultStatus.Failed,
+                    }),
+            ],
         });
 
         // Act
@@ -98,11 +104,13 @@ describe("runCli", () => {
             new Error("too much branch coverage"),
         ];
         const dependencies = createStubRunCliDependencies({
-            convertConfig: () =>
-                Promise.resolve({
-                    errors,
-                    status: ResultStatus.Failed,
-                }),
+            convertConfigs: [
+                () =>
+                    Promise.resolve({
+                        errors,
+                        status: ResultStatus.Failed,
+                    }),
+            ],
         });
 
         // Act
@@ -133,12 +141,14 @@ describe("runCli", () => {
     it("default output should be .eslintrc.js", async () => {
         let defaultConfig;
         const dependencies = createStubRunCliDependencies({
-            convertConfig: parsedArgs => {
-                defaultConfig = parsedArgs.config;
-                return Promise.resolve({
-                    status: ResultStatus.Succeeded,
-                });
-            },
+            convertConfigs: [
+                parsedArgs => {
+                    defaultConfig = parsedArgs.config;
+                    return Promise.resolve({
+                        status: ResultStatus.Succeeded,
+                    });
+                },
+            ],
         });
 
         const status = await runCli(dependencies, createStubArgv());

src/cli/runCli.ts

@@ -1,15 +1,15 @@
 import chalk from "chalk";
-import { EOL } from "os";
 import { Command } from "commander";
-
+import { EOL } from "os";
 import { version } from "../../package.json";
 import { Logger } from "../adapters/logger";
 import { SansDependencies } from "../binding";
 import { convertConfig } from "../conversion/convertConfig";
-import { TSLintToESLintSettings, TSLintToESLintResult, ResultStatus } from "../types";
+import { DEFAULT_VSCODE_SETTINGS_PATH } from "../input/vsCodeSettings";
+import { ResultStatus, ResultWithStatus, TSLintToESLintSettings } from "../types";
 
 export type RunCliDependencies = {
-    convertConfig: SansDependencies<typeof convertConfig>;
+    convertConfigs: SansDependencies<typeof convertConfig>[];
     logger: Logger;
 };
 
@@ -24,6 +24,11 @@ export const runCli = async (
         .option("--package [package]", "package configuration file to convert using")
         .option("--tslint [tslint]", "tslint configuration file to convert using")
         .option("--typescript [typescript]", "typescript configuration file to convert using")
+        .option(
+            "--editor [editor]",
+            "editor configuration file to convert using",
+            DEFAULT_VSCODE_SETTINGS_PATH,
+        )
         .option("-V --version", "output the package version");
 
     const parsedArgv = {
@@ -36,22 +41,38 @@ export const runCli = async (
         return ResultStatus.Succeeded;
     }
 
-    let result: TSLintToESLintResult;
+    for (const convertConfig of dependencies.convertConfigs) {
+        const result = await tryConvertConfig(convertConfig, parsedArgv);
+        if (result.status !== ResultStatus.Succeeded) {
+            logErrorResult(result, dependencies);
+            return result.status;
+        }
+    }
+
+    dependencies.logger.stdout.write(chalk.greenBright("✅ All is well! ✅\n"));
+    return ResultStatus.Succeeded;
+};
+
+const tryConvertConfig = async (
+    config: SansDependencies<typeof convertConfig>,
+    argv: Partial<TSLintToESLintSettings>,
+): Promise<ResultWithStatus> => {
+    let result: ResultWithStatus;
 
     try {
-        result = await dependencies.convertConfig(parsedArgv);
+        result = await config(argv as TSLintToESLintSettings);
     } catch (error) {
         result = {
             errors: [error as Error],
             status: ResultStatus.Failed,
         };
     }
 
-    switch (result.status) {
-        case ResultStatus.Succeeded:
-            dependencies.logger.stdout.write(chalk.greenBright("✅ All is well! ✅\n"));
-            break;
+    return result;
+};
 
+const logErrorResult = (result: ResultWithStatus, dependencies: RunCliDependencies) => {
+    switch (result.status) {
         case ResultStatus.ConfigurationError:
             dependencies.logger.stderr.write(chalk.redBright("❌ "));
             dependencies.logger.stderr.write(chalk.red("Could not start tslint-to-eslint:"));
@@ -72,6 +93,4 @@ export const runCli = async (
             }
             break;
     }
-
-    return result.status;
 };

src/conversion/conversionResults.stubs.ts

@@ -1,4 +1,5 @@
 import { RuleConversionResults } from "../rules/convertRules";
+import { SettingConversionResults } from "../settings/convertSettings";
 
 export const createEmptyConversionResults = (
     overrides: Partial<RuleConversionResults> = {},
@@ -9,3 +10,12 @@ export const createEmptyConversionResults = (
     plugins: new Set(),
     ...overrides,
 });
+
+export const createEmptySettingConversionResults = (
+    overrides: Partial<SettingConversionResults> = {},
+): SettingConversionResults => ({
+    converted: new Map(),
+    failed: [],
+    missing: [],
+    ...overrides,
+});