Skip to content

Add strict-boolean-expression converter #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 19, 2019
Merged

Add strict-boolean-expression converter #237

merged 2 commits into from
Oct 19, 2019

Conversation

KingDarBoja
Copy link
Collaborator

PR Checklist

Overview

  • Added a rule converter for stric-boolean-expressions in the TSLint ruleset.
  • Added proper handling for the options that come with the rule itself.
  • Added tests to make sure that the right comparative rules are being output.
  • Added a notice so that the user is informed of things not automatically converted or covered.
  • Remove comments at converters file of already solved converters.

JoshuaKGoldberg
JoshuaKGoldberg requested changes Oct 13, 2019
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start, but let's hammer out some details on the rule arguments?

@JoshuaKGoldberg JoshuaKGoldberg added the status: waiting for author The PR author should address requested changes label Oct 13, 2019
@JoshuaKGoldberg JoshuaKGoldberg merged commit befe67c into typescript-eslint:master Oct 19, 2019
@KingDarBoja KingDarBoja deleted the feature/strict-boolean-expression branch October 19, 2019 17:08
@JoshuaKGoldberg JoshuaKGoldberg removed the status: waiting for author The PR author should address requested changes label Oct 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing converter: strict-boolean-expressions
2 participants
@KingDarBoja @JoshuaKGoldberg